Labels Milestones

Bugfixes for initCommand #156

Merged

6543 merged 2 commits from 6543/tea:bugfix_loadConfig into master 3 years ago

Conversation 0 Commits 2 Files Changed 1

6543 commented 3 years ago

Collaborator

• Loadconfig again (bug introduced by #151)
• respect --login parameter

* Loadconfig again (bug introduced by #151) * respect --login parameter

6543 added 1 commit 3 years ago

b0be3a3566

🚀

6543 added the kind/bug skip-changelog labels 3 years ago

6543 added this to the v0.4.0 milestone 3 years ago

lunny approved these changes 3 years ago

Dismissed

6543 added 1 commit 3 years ago

6933551ecf

respect --login parameter again

6543 changed title from Bugfix Loadconfig to Bugfixes for initCommand 3 years ago

zeripath approved these changes 3 years ago

Dismissed

zeripath left a comment

Owner

I guess this solves the bug for the present but this is all a bit convoluted
and quite difficult to understand - e.g. there's initCommandLoginOnly()
just below this that appears to use a different way of determining the login.

I think we need to explain these techniques for finding the login - make it
clear where ActiveLogin gets it's login from etc.

I guess this solves the bug for the present but this is all a bit convoluted and quite difficult to understand - e.g. there's initCommandLoginOnly() just below this that appears to use a different way of determining the login. I think we need to explain these techniques for finding the login - make it clear where ActiveLogin gets it's login from etc.

6543 referenced this pull request 3 years ago

Refactor flags.go and config.go #158

6543 referenced this issue from a commit 3 years ago

Bugfixes for initCommand (#156)

6543 merged commit 08a9a9a8ab into master 3 years ago

6543 deleted branch bugfix_loadConfig 3 years ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 08a9a9a8ab.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

kind/breaking kind/bug kind/build kind/dependency kind/deployment kind/docs kind/enhancement kind/feature kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation priority/critical priority/high priority/low priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/has-backport status/has-pull status/needs-backport status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/sdk

No Label kind/breaking kind/bug kind/build kind/dependency kind/deployment kind/docs kind/enhancement kind/feature kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation priority/critical priority/high priority/low priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/has-backport status/has-pull status/needs-backport status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/sdk

Milestone

Set milestone

Clear milestone

No items

No Milestone

v0.4.0

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#156

Write Preview

Loading…

Cancel

Save

There is no content yet.