Bugfixes for initCommand #156

Merged
6543 merged 2 commits from 6543/tea:bugfix_loadConfig into master 2 years ago
6543 commented 2 years ago
Collaborator
  • Loadconfig again (bug introduced by #151)
  • respect --login parameter
* Loadconfig again (bug introduced by #151) * respect --login parameter
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
b0be3a3566
🚀
6543 added the kind/bug skip-changelog labels 2 years ago
6543 added this to the v0.4.0 milestone 2 years ago
lunny approved these changes 2 years ago
Dismissed
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
6933551ecf
respect --login parameter again
6543 changed title from Bugfix Loadconfig to Bugfixes for initCommand 2 years ago
zeripath approved these changes 2 years ago
Dismissed
zeripath left a comment
Owner

I guess this solves the bug for the present but this is all a bit convoluted
and quite difficult to understand - e.g. there's initCommandLoginOnly()
just below this that appears to use a different way of determining the login.

I think we need to explain these techniques for finding the login - make it
clear where ActiveLogin gets it's login from etc.

I guess this solves the bug for the present but this is all a bit convoluted and quite difficult to understand - e.g. there's initCommandLoginOnly() just below this that appears to use a different way of determining the login. I think we need to explain these techniques for finding the login - make it clear where ActiveLogin gets it's login from etc.
6543 referenced this issue from a commit 2 years ago
6543 merged commit 08a9a9a8ab into master 2 years ago
6543 deleted branch bugfix_loadConfig 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 08a9a9a8ab.
Sign in to join this conversation.
Loading…
There is no content yet.