replace flag globals, require context for commands #291

Merged
6543 merged 11 commits from noerw/tea:refactor-global-flags into master 2 years ago
noerw commented 2 years ago
Collaborator

Another big refactor, I'm sorry :( this should be the last one for now..
If needed I can split this up, but all changes depend on each other anyway.

  • removes global flag values in cmd/flags (closes #158)
  • introduces TeaContext, a wrapper around cli.Context
  • simplifies InitCommand() call signature to return TeaContext
  • checks command requirements on TeaContext via ctx.Ensure()
context

Since #285 all commands can be run outside of a git repo.
For some commands this was desired, for others requirements are too loose now.
This readds requirement checks in a more flexible way.
Could be considered a bugfix and should go into v0.6.0

Another big refactor, I'm sorry :( this should be the last one for now.. If needed I can split this up, but all changes depend on each other anyway. - removes global flag values in `cmd/flags` (closes #158) - introduces `TeaContext`, a wrapper around `cli.Context` - simplifies `InitCommand()` call signature to return `TeaContext` - checks command requirements on TeaContext via `ctx.Ensure()` ##### context Since #285 all commands can be run outside of a git repo. For some commands this was desired, for others requirements are too loose now. This readds requirement checks in a more flexible way. Could be considered a bugfix and should go into v0.6.0
noerw added this to the v0.6.0 milestone 2 years ago
noerw added the
kind/enhancement
kind/refactor
status/needs-reviews
labels 2 years ago
noerw added 4 commits 2 years ago
continuous-integration/drone/pr Build is failing Details
98cebeb04f
ensure context for each command
noerw added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
a60fd06a57
make linter happy
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
91502cd219
Merge branch 'master' into refactor-global-flags
noerw added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
9919dda680
move TeaContext & InitCommand to modules/context
6543 added 1 commit 2 years ago
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
d5286478a5
CI.restart()
6543 modified the milestone from v0.6.0 to v0.7.0 2 years ago
noerw added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
c7dd68b5c5
Merge branch 'master' into refactor-global-flags
lunny approved these changes 2 years ago
Dismissed
Owner

Please resolve the conflicts.

Please resolve the conflicts.
khmarbaise approved these changes 2 years ago
Dismissed
6543 removed the
status/needs-reviews
label 2 years ago
noerw added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
98a775e058
Merge branch 'master' into refactor-global-flags
6543 approved these changes 2 years ago
Dismissed
6543 merged commit dc67630b64 into master 2 years ago
6543 referenced this issue from a commit 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as dc67630b64.
Sign in to join this conversation.
Loading…
There is no content yet.