Show PR CI status #306

Merged
6543 merged 8 commits from noerw/tea:issue-117-pr-status into master 4 months ago
noerw commented 4 months ago

fixes #117

image

fixes #117 ![image](/attachments/04cdba0b-df2f-4802-b0d9-1e982e3193e9)
214 KiB
noerw added this to the v0.7.0 milestone 4 months ago
noerw added the
kind/enhancement
label 4 months ago
noerw added 3 commits 4 months ago
6543 reviewed 4 months ago
modules/print/pull.go Outdated
// PullDetails print an pull rendered to stdout
func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview) {
func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview, ciStatus *gitea.CombinedStatus) {
// func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview, ciStatus []*gitea.Status) {
6543 commented 4 months ago
Poster
Collaborator

Pull wip?

Pull wip?
noerw marked this conversation as resolved
noerw added 1 commit 4 months ago
29d09b2ce2
remove line
noerw added 1 commit 4 months ago
42781ab9f8
show merged state
lunny approved these changes 4 months ago
6543 added 1 commit 4 months ago
9317a1a519 Merge branch 'master' into issue-117-pr-status
6543 reviewed 4 months ago
modules/print/pull.go Outdated
case gitea.ReviewStateApproved,
gitea.ReviewStateRequestChanges,
gitea.ReviewStateRequestReview:
revMap[review.Reviewer.UserName] = review.State
6543 commented 4 months ago
Poster
Collaborator

this remove dedublicate review states!!

before:

@lunny: APPROVED @6543: APPROVED

now:

* REQUEST_REVIEW by @lunny, @6543
* APPROVED by @lunny, @lunny, @6543

I like the new look, but you still have to only get latest state for each user

this remove dedublicate review states!! before: ``` @lunny: APPROVED @6543: APPROVED ``` now: ```md * REQUEST_REVIEW by @lunny, @6543 * APPROVED by @lunny, @lunny, @6543 ``` I like the new look, but you still have to only get latest state for each user
6543 commented 4 months ago
Poster
Collaborator

example was: tea pr 309

example was: `tea pr 309`
noerw commented 4 months ago
Poster

Oh right. And I thought I was fixing a bug: Thought you were aiming to deduplicate Approved/Rejected states. IMO we should deduplicate both.

I just tried to filter by review.Stale, but that's never true. wtf is this for?

Oh right. And I thought I was fixing a bug: Thought you were aiming to deduplicate Approved/Rejected states. IMO we should deduplicate both. I just tried to filter by `review.Stale`, but that's never true. wtf is this for?
6543 commented 4 months ago
Poster
Collaborator

Stale is a idication if the review took place on a different state as the pull is now (pull diff has changed since reviewed)

Stale is a idication if the review took place on a different state as the pull is now (pull diff has changed since reviewed)
noerw commented 4 months ago
Poster

fixed, output is now

  • APPROVED by @lunny, @6543     
fixed, output is now ``` • APPROVED by @lunny, @6543 ```
6543 marked this conversation as resolved
6543 requested changes 4 months ago
6543 left a comment

as per comment

noerw added 1 commit 4 months ago
3146dfaf68
deduplicate reviews by user
noerw added 1 commit 4 months ago
32620456a5
Merge branch 'master' into issue-117-pr-status
6543 approved these changes 4 months ago
6543 left a comment

nice ♥

6543 merged commit 83b73ce78e into master 4 months ago
6543 referenced this issue from a commit 4 months ago
Poster

Just for reference, I think I didn't mention it here:
tea pr <idx> soft-fails on fetching CI results for PRs that have no CI, see https://gitea.com/gitea/go-sdk/issues/468

Just for reference, I think I didn't mention it here: `tea pr <idx>` soft-fails on fetching CI results for PRs that have no CI, see https://gitea.com/gitea/go-sdk/issues/468

Reviewers

lunny approved these changes 4 months ago
6543 approved these changes 4 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 83b73ce78e.
Sign in to join this conversation.
Loading…
There is no content yet.