gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Show PR CI status #306

Merged
6543 merged 8 commits from noerw/tea:issue-117-pr-status into master 2020-12-16 17:16:51 +00:00
Conversation 1 Commits 8 Files Changed 3 +78 -18
noerw commented 2020-12-15 21:22:14 +00:00
Member
Copy Link

fixes #117

image

fixes #117 ![image](/attachments/04cdba0b-df2f-4802-b0d9-1e982e3193e9)
image.png
214 KiB
❤️ 2
noerw added this to the v0.7.0 milestone 2020-12-15 21:22:14 +00:00
noerw added the
kind
enhancement
 label 2020-12-15 21:22:14 +00:00
noerw added 3 commits 2020-12-15 21:22:15 +00:00
put conflict info in status list
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7b2c590ea4
6543 reviewed 2020-12-15 22:14:59 +00:00
Dismissed
modules/print/pull.go Outdated
@ -14,2 +23,3 @@
// PullDetails print an pull rendered to stdout
func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview) {
func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview, ciStatus *gitea.CombinedStatus) {
// func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview, ciStatus []*gitea.Status) {
6543 commented 2020-12-15 22:14:59 +00:00
Owner
Copy Link

Pull wip?

Pull wip?
noerw marked this conversation as resolved
noerw added 1 commit 2020-12-15 22:56:21 +00:00
remove line
All checks were successful
continuous-integration/drone/pr Build is passing
Details
29d09b2ce2
noerw added 1 commit 2020-12-16 03:38:32 +00:00
show merged state
All checks were successful
continuous-integration/drone/pr Build is passing
Details
42781ab9f8
lunny approved these changes 2020-12-16 11:25:48 +00:00
Dismissed
6543 added 1 commit 2020-12-16 16:02:53 +00:00
Merge branch 'master' into issue-117-pr-status
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9317a1a519
6543 reviewed 2020-12-16 16:09:05 +00:00
Dismissed
modules/print/pull.go Outdated
@ -43,4 +60,3 @@
case gitea.ReviewStateApproved,
gitea.ReviewStateRequestChanges,
gitea.ReviewStateRequestReview:
revMap[review.Reviewer.UserName] = review.State
6543 commented 2020-12-16 16:09:05 +00:00
Owner
Copy Link

this remove dedublicate review states!!

before:

@lunny: APPROVED @6543: APPROVED

now:

* REQUEST_REVIEW by @lunny, @6543
* APPROVED by @lunny, @lunny, @6543

I like the new look, but you still have to only get latest state for each user

this remove dedublicate review states!! before: ``` @lunny: APPROVED @6543: APPROVED ``` now: ```md * REQUEST_REVIEW by @lunny, @6543 * APPROVED by @lunny, @lunny, @6543 ``` I like the new look, but you still have to only get latest state for each user
6543 commented 2020-12-16 16:09:28 +00:00
Owner
Copy Link

example was: tea pr 309

example was: `tea pr 309`
noerw commented 2020-12-16 16:28:47 +00:00
Author
Member
Copy Link

Oh right. And I thought I was fixing a bug: Thought you were aiming to deduplicate Approved/Rejected states. IMO we should deduplicate both.

I just tried to filter by review.Stale, but that's never true. wtf is this for?

Oh right. And I thought I was fixing a bug: Thought you were aiming to deduplicate Approved/Rejected states. IMO we should deduplicate both. I just tried to filter by `review.Stale`, but that's never true. wtf is this for?
6543 commented 2020-12-16 16:54:11 +00:00
Owner
Copy Link

Stale is a idication if the review took place on a different state as the pull is now (pull diff has changed since reviewed)

Stale is a idication if the review took place on a different state as the pull is now (pull diff has changed since reviewed)
noerw commented 2020-12-16 16:59:19 +00:00
Author
Member
Copy Link

fixed, output is now

  • APPROVED by @lunny, @6543
fixed, output is now ``` • APPROVED by @lunny, @6543 ```
6543 marked this conversation as resolved
6543 requested changes 2020-12-16 16:11:31 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

as per comment

as per comment
noerw added 1 commit 2020-12-16 16:58:55 +00:00
deduplicate reviews by user
All checks were successful
continuous-integration/drone/pr Build is passing
Details
3146dfaf68
noerw added 1 commit 2020-12-16 17:11:45 +00:00
Merge branch 'master' into issue-117-pr-status
All checks were successful
continuous-integration/drone/pr Build is passing
Details
32620456a5
6543 approved these changes 2020-12-16 17:16:23 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

nice ♥

nice ♥
6543 merged commit 83b73ce78e into master 2020-12-16 17:16:51 +00:00
6543 referenced this issue from a commit 2020-12-16 17:16:51 +00:00
Show PR CI status (#306)
noerw commented 2020-12-16 17:22:05 +00:00
Author
Member
Copy Link

Just for reference, I think I didn't mention it here:
tea pr <idx> soft-fails on fetching CI results for PRs that have no CI, see gitea/go-sdk#468

Just for reference, I think I didn't mention it here: `tea pr <idx>` soft-fails on fetching CI results for PRs that have no CI, see https://gitea.com/gitea/go-sdk/issues/468
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#306
No description provided.
Delete Branch "noerw/tea:issue-117-pr-status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?