gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Detect markdown line width, resolve relative URLs #332

Merged
zeripath merged 10 commits from noerw/tea:markdown-linewrap into master 2021-03-12 12:28:47 +00:00
Conversation 4 Commits 10 Files Changed 82 +7709 -316
noerw commented 2021-03-02 21:24:55 +00:00
Member
Copy Link

this is semi-blocked by https://github.com/charmbracelet/glamour/pull/96, but behaviour isn't really worse than the previous behaviour (most links work, some are still broken)

testcase for link resolver

tea pr 332
tea checkout 332 && make install && tea pr 332
~~this is semi-blocked by https://github.com/charmbracelet/glamour/pull/96, but behaviour isn't really worse than the previous behaviour (most links work, some are still broken)~~ #### testcase for link resolver ``` tea pr 332 tea checkout 332 && make install && tea pr 332 ``` - [rel](./332) - [abs](/gitea/tea/pulls/332) - [full](https://gitea.com/gitea/tea/pulls/332)
noerw added 2 commits 2021-03-02 21:24:56 +00:00
resolve markdown links relative to issue content URL 
absolute URLs are not properly resolved due to
https://github.com/charmbracelet/glamour/pull/96
without this fix the behaviour isn't really worse than before this commit.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0b661bd2fc
noerw added the
kind
enhancement
status/blocked
 labels 2021-03-02 21:25:27 +00:00
noerw removed the
status/blocked
 label 2021-03-02 21:38:52 +00:00
noerw changed title from detect markdown line width to detect markdown line width, resolve relative URLs 2021-03-04 19:07:20 +00:00
6543 reviewed 2021-03-05 10:16:17 +00:00
Dismissed
modules/print/comment.go Outdated
@ -22,3 +22,3 @@
"Comments\n%s",
strings.Join(out, "\n"),
))
), comments[0].HTMLURL)
6543 commented 2021-03-05 10:16:17 +00:00
Owner
Copy Link

if len comments == 0 ... nil pointer exeption!

if len comments == 0 ... nil pointer exeption!
6543 marked this conversation as resolved
6543 added 1 commit 2021-03-05 10:20:33 +00:00
no nil exeption
All checks were successful
continuous-integration/drone/pr Build is passing
Details
aa6d49ab09
6543 added 1 commit 2021-03-05 10:22:58 +00:00
speedup ?
All checks were successful
continuous-integration/drone/pr Build is passing
Details
56b7ab9364
6543 approved these changes 2021-03-05 10:26:14 +00:00
Dismissed
6543 added 1 commit 2021-03-05 10:26:21 +00:00
Merge branch 'master' into markdown-linewrap
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6e53b32637
6543 added 1 commit 2021-03-05 10:29:11 +00:00
Merge branch 'master' into markdown-linewrap
All checks were successful
continuous-integration/drone/pr Build is passing
Details
19a55ada09
6543 requested changes 2021-03-05 10:54:33 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

sorry got:

  • rel https://gitea.com/gitea/tea/pulls/332                                                                         
  • abs https://gitea.com/gitea/tea/pulls/gitea/tea/pulls/332                                                         
  • full https://gitea.com/gitea/tea/pulls/332

while testing tea issue 332

sorry got: ``` • rel https://gitea.com/gitea/tea/pulls/332 • abs https://gitea.com/gitea/tea/pulls/gitea/tea/pulls/332 • full https://gitea.com/gitea/tea/pulls/332 ``` while testing `tea issue 332`
6543 added 1 commit 2021-03-05 11:04:01 +00:00
use replace to get upstream patch
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9134a7b2b8
6543 approved these changes 2021-03-05 11:04:44 +00:00
Dismissed
6543 added this to the v0.7.0 milestone 2021-03-05 11:05:03 +00:00
6543 added 1 commit 2021-03-05 13:26:38 +00:00
Merge branch 'master' into markdown-linewrap
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ba10cc7924
6543 added 1 commit 2021-03-05 13:31:43 +00:00
update
All checks were successful
continuous-integration/drone/pr Build is passing
Details
76f150b595
noerw commented 2021-03-06 20:10:12 +00:00
Author
Member
Copy Link

From discussion at https://github.com/charmbracelet/glamour/pull/96 i understood that we probably should resolve URLs relative to repo.HTMLURL, instead of the issue / comment URL.
This enables cases where a file is linked from the repo file tree etc, and follows what the gitea web UI does.
Will commit a solution later..

some gitea markdown testing (github equivalent)

From discussion at https://github.com/charmbracelet/glamour/pull/96 i understood that we probably should resolve URLs relative to repo.HTMLURL, instead of the issue / comment URL. This enables cases where a file is linked from the repo file tree etc, and follows what the gitea web UI does. Will commit a solution later.. #### some gitea markdown testing ([`github` equivalent](https://github.com/charmbracelet/glamour/pull/96#issuecomment-791417905)) - [src/branch/master/modules/print/markdown.go](src/branch/master/modules/print/markdown.go) - [modules/print/markdown.go](modules/print/markdown.go) - [/src/branch/master/modules/print/markdown.go](/src/branch/master/modules/print/markdown.go) - [/modules/print/markdown.go](/modules/print/markdown.go)
noerw added the
status/wip
 label 2021-03-06 20:10:21 +00:00
6543 changed title from detect markdown line width, resolve relative URLs to Detect markdown line width, resolve relative URLs 2021-03-11 18:15:30 +00:00
6543 commented 2021-03-11 18:33:11 +00:00
Owner
Copy Link

@noerw status?

@noerw status?
6543 modified the milestone from v0.7.0 to v0.8.0 2021-03-11 23:40:08 +00:00
noerw commented 2021-03-12 03:53:52 +00:00
Author
Member
Copy Link

@6543 didn't find the time yet. i guess we can merge + change behaviour in a followup, if you want to release 0.7.0 now

@6543 didn't find the time yet. i guess we can merge + change behaviour in a followup, if you want to release 0.7.0 now
👍 1
noerw removed the
status/wip
 label 2021-03-12 11:28:55 +00:00
noerw modified the milestone from v0.8.0 to v0.7.0 2021-03-12 11:29:00 +00:00
noerw added the
status/needs-reviews
 label 2021-03-12 11:29:11 +00:00
6543 added 1 commit 2021-03-12 11:36:41 +00:00
Merge branch 'master' into markdown-linewrap
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8fac65abd4
6543 approved these changes 2021-03-12 11:45:35 +00:00
Dismissed
zeripath approved these changes 2021-03-12 12:28:39 +00:00
Dismissed
zeripath merged commit 222d0501df into master 2021-03-12 12:28:47 +00:00
lafriks approved these changes 2021-03-12 12:29:12 +00:00
Dismissed
lafriks deleted branch markdown-linewrap 2021-03-12 12:29:24 +00:00
lafriks commented 2021-03-12 12:29:52 +00:00
Member
Copy Link

I was few seconds late ?

I was few seconds late ?
😆 2
6543 removed the
status/needs-reviews
 label 2021-03-12 12:32:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#332
No description provided.
Delete Branch "noerw/tea:markdown-linewrap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?