Don't require a body for comment PR reviews #399

Merged
zeripath merged 3 commits from noerw/tea:fix/372 into master 1 month ago
noerw commented 1 month ago

fixes #372

fixes #372
noerw added this to the v0.8.0 milestone 1 month ago
noerw added the
kind/enhancement
upstream/gitea
labels 1 month ago
noerw added 1 commit 1 month ago
1d79f6409d dont require a body for comment PR reviews
noerw added 1 commit 1 month ago
ff0fcf7a03 Merge branch 'master' into fix/372
6543 modified the milestone from v0.8.0 to v0.9.0 1 month ago
6543 added the
status/blocked
label 1 month ago
Collaborator

gitea's ui also cant do that - this has to be canged everywhere ...

gitea's ui also cant do that - this has to be canged everywhere ...
Poster

@6543 According to https://github.com/go-gitea/gitea/pull/16229 it does work, thus the change to the API was made.

@6543 According to https://github.com/go-gitea/gitea/pull/16229 it does work, thus the change to the API was made.
noerw reviewed 1 month ago
// comment
var promptOpts survey.AskOpt
if state == gitea.ReviewStateComment || state == gitea.ReviewStateRequestChanges {
if (state == gitea.ReviewStateComment && len(codeComments) == 0) || state == gitea.ReviewStateRequestChanges {
noerw commented 1 month ago
Poster

this is a test using the webui to verify my claim in #399

this is a test using the webui to verify my claim in https://gitea.com/gitea/tea/pulls/399#issuecomment-592704
6543 commented 1 month ago
Poster
Collaborator

well I'm ok with it - since the gitea will have the last word anyway ...

well I'm ok with it - since the gitea will have the last word anyway ...
6543 removed the
status/blocked
upstream/gitea
labels 1 month ago
6543 approved these changes 1 month ago
6543 modified the milestone from v0.9.0 to v0.8.0 1 month ago
6543 added 1 commit 1 month ago
d1492edc19 Merge branch 'master' into fix/372
zeripath approved these changes 1 month ago
zeripath merged commit 802bdf7dc5 into master 1 month ago
6543 deleted branch fix/372 1 month ago

Reviewers

6543 approved these changes 1 month ago
zeripath approved these changes 1 month ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 802bdf7dc5.
Sign in to join this conversation.
Loading…
There is no content yet.