Add user list command #427

Open
techknowlogick wants to merge 2 commits from admin-list-users into master
Owner
There is no content yet.
techknowlogick added this to the v0.9.0 milestone 4 months ago
techknowlogick added the
kind/feature
label 4 months ago
techknowlogick added 1 commit 4 months ago
1a1a186a22
Add user list command
techknowlogick added 1 commit 4 months ago
340f8b721f
correct documentation
noerw requested changes 4 months ago
Action: func(cmd *cli.Context) error {
// TODO: this is just a stub for all admin actions
// there is no default admin action
return nil
noerw commented 4 months ago
Collaborator

return cli.ShowCommandHelp(cmd, "") would be a good default behaviour i think

`return cli.ShowCommandHelp(cmd, "")` would be a good default behaviour i think
return err
}
fields, err := userFieldsFlag.GetValues(cmd)
noerw commented 4 months ago
Collaborator

if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)

if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)
)
var cmdAdminUsers = cli.Command{
Name: "user",
noerw commented 4 months ago
Collaborator

users

`users`
catSetup = "SETUP"
catEntities = "ENTITIES"
catHelpers = "HELPERS"
catAdmin = "ADMIN"
noerw commented 4 months ago
Collaborator

if we put all admin commands under the tea admin namespace, do we need a ADMIN category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm.
maybe rename it to a more generic MISC?

if we put all admin commands under the `tea admin` namespace, do we need a `ADMIN` category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm. maybe rename it to a more generic `MISC`?
Owner

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.

Reviewers

noerw requested changes 4 months ago
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
continuous-integration/drone/push Build is passing
This pull request has changes conflicting with the target branch.
main.go
Sign in to join this conversation.
Loading…
There is no content yet.