gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add user list command #427

Merged
6543 merged 9 commits from admin-list-users into main 2022-09-13 19:49:35 +00:00
Conversation 2 Commits 9 Files Changed 6 +122 -1
techknowlogick commented 2021-10-04 20:27:09 +00:00
Owner
Copy Link
No description provided.
👍 1
techknowlogick added this to the v0.9.0 milestone 2021-10-04 20:27:09 +00:00
techknowlogick added the
kind
feature
 label 2021-10-04 20:27:09 +00:00
techknowlogick added 1 commit 2021-10-04 20:27:10 +00:00
Add user list command
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
1a1a186a22
techknowlogick added 1 commit 2021-10-04 20:27:56 +00:00
correct documentation
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
340f8b721f
noerw requested changes 2021-10-05 07:41:02 +00:00
cmd/admin.go
@ -0,0 +16,4 @@
Action: func(cmd *cli.Context) error {
// TODO: this is just a stub for all admin actions
// there is no default admin action
return nil
noerw commented 2021-10-05 07:36:24 +00:00
Member
Copy Link

return cli.ShowCommandHelp(cmd, "") would be a good default behaviour i think

`return cli.ShowCommandHelp(cmd, "")` would be a good default behaviour i think
noerw marked this conversation as resolved
cmd/admin/users/list.go Outdated
@ -0,0 +43,4 @@
return err
}
fields, err := userFieldsFlag.GetValues(cmd)
noerw commented 2021-10-05 07:40:22 +00:00
Member
Copy Link

if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)

if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)
noerw marked this conversation as resolved
cmd/admin_users.go Outdated
@ -0,0 +13,4 @@
)
var cmdAdminUsers = cli.Command{
Name: "user",
noerw commented 2021-10-05 07:40:41 +00:00
Member
Copy Link

users

`users`
noerw marked this conversation as resolved
cmd/categories.go Outdated
@ -8,4 +8,5 @@ var (
catSetup = "SETUP"
catEntities = "ENTITIES"
catHelpers = "HELPERS"
catAdmin = "ADMIN"
noerw commented 2021-10-05 07:38:52 +00:00
Member
Copy Link

if we put all admin commands under the tea admin namespace, do we need a ADMIN category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm.
maybe rename it to a more generic MISC?

if we put all admin commands under the `tea admin` namespace, do we need a `ADMIN` category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm. maybe rename it to a more generic `MISC`?
noerw marked this conversation as resolved
lunny commented 2021-10-09 04:36:32 +00:00
Owner
Copy Link

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.
noerw commented 2022-03-16 21:33:07 +00:00
Member
Copy Link

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.

@lunny The API /admin/users doesn't provide this functionality. There is /users/search?q=, but that also just searches in the name field.
I'd say such feature requires upstream changes.

> How about add statistics for users and search by name and email keyword? It seems list users is not very useful. @lunny The API `/admin/users` doesn't provide this functionality. There is `/users/search?q=`, but that also just searches in the name field. I'd say such feature requires upstream changes.
techknowlogick added 1 commit 2022-03-17 02:09:42 +00:00
Enhance Admin User Listing (#427) (#471) 
This is a patch for #427:

- merge `master`
- address my own review
- add some more printable fields

Co-authored-by: kellya <kellya@noreply.gitea.io>
Co-authored-by: Ikko Ashimine <eltociear@noreply.gitea.io>
Co-authored-by: arkamar <arkamar@noreply.gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Norwin <git@nroo.de>
Reviewed-on: #471
Co-authored-by: Norwin <noerw@noreply.gitea.io>
Co-committed-by: Norwin <noerw@noreply.gitea.io>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is passing
Details
3aaac9b0d0
noerw approved these changes 2022-03-26 11:38:49 +00:00
6543 added 1 commit 2022-03-28 23:16:29 +00:00
Merge branch 'master' into admin-list-users
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
4cabb23230
6543 closed this pull request 2022-03-28 23:18:58 +00:00
6543 reopened this pull request 2022-03-28 23:19:05 +00:00
6543 added 1 commit 2022-03-28 23:35:06 +00:00
Merge branch 'master' into admin-list-users
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/pr Build was killed
Details
355db9bc36
6543 added 1 commit 2022-03-28 23:35:28 +00:00
CI.restart()
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/pr Build is failing
Details
09de649272
6543 closed this pull request 2022-03-28 23:39:17 +00:00
6543 reopened this pull request 2022-03-28 23:39:26 +00:00
noerw modified the milestone from v0.9.0 to v0.10.0 2022-09-13 18:30:31 +00:00
6543 added 1 commit 2022-09-13 19:11:12 +00:00
Merge branch 'main' into admin-list-users
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/pr Build was killed
Details
92252e6284
6543 reviewed 2022-09-13 19:12:09 +00:00
6543 approved these changes 2022-09-13 19:16:14 +00:00
noerw added 2 commits 2022-09-13 19:28:16 +00:00
improve cmd categories
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/pr Build is passing
Details
d1efad5660
6543 merged commit 832136b6d4 into main 2022-09-13 19:49:35 +00:00
6543 referenced this issue from a commit 2022-09-13 19:49:35 +00:00
Add user list command (#427)
6543 deleted branch admin-list-users 2022-09-13 19:49:35 +00:00
6543 modified the milestone from v0.10.0 to v0.9.0 2022-09-13 20:03:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
noerw
6543
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.9.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#427
No description provided.
Delete Branch "admin-list-users"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?