Add user list command #427

Open
techknowlogick wants to merge 6 commits from admin-list-users into master
There is no content yet.
techknowlogick added this to the v0.9.0 milestone 10 months ago
techknowlogick added the
kind/feature
label 10 months ago
techknowlogick added 1 commit 10 months ago
1a1a186a22
Add user list command
techknowlogick added 1 commit 10 months ago
340f8b721f
correct documentation
noerw requested changes 10 months ago
Action: func(cmd *cli.Context) error {
// TODO: this is just a stub for all admin actions
// there is no default admin action
return nil
Collaborator

return cli.ShowCommandHelp(cmd, "") would be a good default behaviour i think

`return cli.ShowCommandHelp(cmd, "")` would be a good default behaviour i think
noerw marked this conversation as resolved
return err
}
fields, err := userFieldsFlag.GetValues(cmd)
Collaborator

if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)

if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)
noerw marked this conversation as resolved
)
var cmdAdminUsers = cli.Command{
Name: "user",
Collaborator

users

`users`
noerw marked this conversation as resolved
catSetup = "SETUP"
catEntities = "ENTITIES"
catHelpers = "HELPERS"
catAdmin = "ADMIN"
Collaborator

if we put all admin commands under the tea admin namespace, do we need a ADMIN category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm.
maybe rename it to a more generic MISC?

if we put all admin commands under the `tea admin` namespace, do we need a `ADMIN` category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm. maybe rename it to a more generic `MISC`?
noerw marked this conversation as resolved
Owner

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.
Collaborator

How about add statistics for users and search by name and email keyword? It seems list users is not very useful.

@lunny The API /admin/users doesn't provide this functionality. There is /users/search?q=, but that also just searches in the name field.
I'd say such feature requires upstream changes.

> How about add statistics for users and search by name and email keyword? It seems list users is not very useful. @lunny The API `/admin/users` doesn't provide this functionality. There is `/users/search?q=`, but that also just searches in the name field. I'd say such feature requires upstream changes.
techknowlogick added 1 commit 5 months ago
3aaac9b0d0 Enhance Admin User Listing (#427) (#471)
noerw approved these changes 5 months ago
6543 added 1 commit 4 months ago
4cabb23230
Merge branch 'master' into admin-list-users
6543 closed this pull request 4 months ago
6543 reopened this pull request 4 months ago
6543 added 1 commit 4 months ago
355db9bc36
Merge branch 'master' into admin-list-users
6543 added 1 commit 4 months ago
09de649272
CI.restart()
6543 closed this pull request 4 months ago
6543 reopened this pull request 4 months ago

Reviewers

noerw approved these changes 5 months ago
Some checks reported errors
continuous-integration/drone/push Build was killed
continuous-integration/drone/pr Build is failing
Required
Details
This Pull Request doesn't have enough approvals yet. 1 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Loading…
There is no content yet.