Add user list command #427
Open
techknowlogick
wants to merge 6 commits from admin-list-users
into master
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'admin-list-users'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Action: func(cmd *cli.Context) error {
// TODO: this is just a stub for all admin actions
// there is no default admin action
return nil
return cli.ShowCommandHelp(cmd, "")
would be a good default behaviour i thinkreturn err
}
fields, err := userFieldsFlag.GetValues(cmd)
if you put that before the request, flag validation will fail faster (i.e. before waiting for the request)
)
var cmdAdminUsers = cli.Command{
Name: "user",
users
catSetup = "SETUP"
catEntities = "ENTITIES"
catHelpers = "HELPERS"
catAdmin = "ADMIN"
if we put all admin commands under the
tea admin
namespace, do we need aADMIN
category? the admin command will be the only one in this category.. though I agree it shouldn't be in any of the existing categories.. hm.maybe rename it to a more generic
MISC
?How about add statistics for users and search by name and email keyword? It seems list users is not very useful.
@lunny The API
/admin/users
doesn't provide this functionality. There is/users/search?q=
, but that also just searches in the name field.I'd say such feature requires upstream changes.
Reviewers