Refactor errorhandling in getReleaseByTag() #477

Merged
6543 merged 1 commits from noerw/tea:fix-errorhandling into master 2022-03-25 13:41:09 +00:00
3 changed files with 2 additions and 12 deletions

View File

@ -54,10 +54,6 @@ func runReleaseDelete(cmd *cli.Context) error {
if err != nil {
return err
}
if release == nil {
return nil
}
_, err = client.DeleteRelease(ctx.Owner, ctx.Repo, release.ID)
if err != nil {
return err

View File

@ -72,10 +72,6 @@ func runReleaseEdit(cmd *cli.Context) error {
if err != nil {
return err
}
if release == nil {
return nil
}
var isDraft, isPre *bool
if ctx.IsSet("draft") {
isDraft = gitea.OptionalBool(strings.ToLower(ctx.String("draft"))[:1] == "t")

View File

@ -50,14 +50,12 @@ func getReleaseByTag(owner, repo, tag string, client *gitea.Client) (*gitea.Rele
return nil, err
}
if len(rl) == 0 {
fmt.Println("Repo does not have any release")
return nil, nil
return nil, fmt.Errorf("Repo does not have any release")
}
for _, r := range rl {
if r.TagName == tag {
return r, nil
}
}
fmt.Println("Release tag does not exist")
return nil, nil
return nil, fmt.Errorf("Release tag does not exist")
}