WIP: improve sshcert authentication #507

People really should use ssh-agent but in the case they don't ask for
the passphrase. We do not save the passphrase, so for every action tea
will ask their passphrase.

Use upstream go-sdk

continuous-integration/drone/pr Build is passing

Details

02e77d463f

Merge branch 'master' into sshcert

continuous-integration/drone/pr Build is failing

Details

4292e79cbd

Merge branch 'main' into sshcert 0b7a00651e

drop unused Login.SSHAgent field 6cd92edc83

refactor: create subpackage modules/interact/prompts 013419bec8

as a preparation for another refactor to avoid an import cycle

fix bug with default value of prompts.Select() 7493ee2ce7

rework login.Client() http-signing logic 82f392ebec

- add more checks
- avoid importing survey in modules/config (importing modules/interact
  in modules/config is still not great, but I don't see how this could
  be solved without making the Client() api very awkward).

rework interactive tea login add prompts: 130ec852c6

- don't make the login method selection a two-prompt process
  (provide all 3 options first)
- don't ask about the SSHKey path again, when using the new auth method

NOTE: the SSHKey path prompt could be removed completely, as users that
have want to use a custom key, would probably use LoginMethodSsh.
However that method does not work with ecdsa-sha2-nistp521 and other key
types - users with that sort of key still may need this option.

minor variable rename b117c53871

Merge branch 'main' into sshcert-noerw

continuous-integration/drone/pr Build is failing

Details

01ee577d1d

6543 added 1 commit 2022-09-14 23:43:18 +00:00

Merge branch 'master' into sshcert-noerw

continuous-integration/drone/pr Build is failing

Details

a08044da40

6543 reviewed 2022-09-14 23:50:01 +00:00

modules/interact/prompts/prompts.go Outdated

						
				@ -0,0 +129,4 @@

				}

				// Select creates a generic select prompt, with processing of custom values or none-option.

				func Select(prompt string, options []string, customVal, noneVal string) (string, error) {

6543 commented

2022-09-14 23:50:01 +00:00

can options have len = 0 ?

if so we could get a out of slice access issue at L138

can options have len = 0 ? if so we could get a out of slice access issue at L138

6543 commented

2022-09-15 00:05:10 +00:00

yes if it's 0 then the Select is wrong used anyway ...

👍 1

6543 marked this conversation as resolved

6543 added 2 commits 2022-09-14 23:59:44 +00:00

fix lint issue and unexport as not needed 5415bd9a02

fix lint

continuous-integration/drone/pr Build is passing

Details

a154f39dde

6543 commented

2022-09-15 00:06:55 +00:00

@noerw ok now I'll wait until u make it non wip ;)

6543 approved these changes 2022-09-26 20:34:11 +00:00

continuous-integration/drone/pr Build is passing

Details

check-and-test / check-and-test (pull_request)

Required

This pull request has changes conflicting with the target branch.

modules/interact/login.go
modules/interact/prompts.go

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u sshcert-noerw:noerw-sshcert-noerw

git checkout noerw-sshcert-noerw

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#507