gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Handle Team Reviews #515

Merged
6543 merged 4 commits from 6543/tea:handle_team-reviews into main 2022-09-29 02:49:24 +00:00
Conversation 3 Commits 4 Files Changed 1 +26 -11
6543 commented 2022-09-27 11:38:49 +00:00
Owner
Copy Link

at the moment we crash with an nil exeption if there exist team reviews

this fix it and add support to display them

to test

use old tea and exec: tea pr 515 against this pull
then test with patched version :)

at the moment we crash with an nil exeption if there exist team reviews this fix it and add support to display them ## to test use old tea and exec: `tea pr 515` against this pull then test with patched version :)
6543 added this to the v0.10.0 milestone 2022-09-27 11:38:49 +00:00
6543 added the
kind/bug
kind
enhancement
 labels 2022-09-27 11:38:49 +00:00
6543 added 1 commit 2022-09-27 11:38:50 +00:00
dont crash, display team reviews
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a6849ccf1a
6543 commented 2022-09-27 11:39:26 +00:00
Author
Owner
Copy Link

![](https://gitea.com/attachments/0e317bfa-cd05-4d50-a6b7-f8f281559988)
2022-09-27_13-44.png
35 KiB
6543 reviewed 2022-09-27 11:40:01 +00:00
modules/print/pull.go Outdated
@ -19,6 +19,8 @@ var ciStatusSymbols = map[gitea.StatusState]string{
gitea.StatusFailure: "❌ ",
}
const teamSymbol = "?‍?‍?"
6543 commented 2022-09-27 11:40:01 +00:00
Author
Owner
Copy Link

if there is a better icon please tell :)

if there is a better icon please tell :)
6543 marked this conversation as resolved
6543 requested review from Maintainers 2022-09-27 11:40:56 +00:00
noerw reviewed 2022-09-27 11:41:58 +00:00
modules/print/pull.go Outdated
@ -19,6 +19,8 @@ var ciStatusSymbols = map[gitea.StatusState]string{
gitea.StatusFailure: "❌ ",
}
const teamSymbol = "?‍?‍?"
noerw commented 2022-09-27 11:41:58 +00:00
Member
Copy Link

:D I'd leave that out, @foo/bar clearly identifies this as a team already.
It doesn't render in my terminals anyway

:D I'd leave that out, @foo/bar clearly identifies this as a team already. It doesn't render in my terminals anyway
👍 1
6543 commented 2022-09-27 11:43:39 +00:00
Author
Owner
Copy Link

rm'ed

rm'ed
noerw marked this conversation as resolved
noerw approved these changes 2022-09-27 11:42:57 +00:00
6543 added 1 commit 2022-09-27 11:43:27 +00:00
no teamSymbol
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9c1ab6649c
6543 requested review from Maintainers 2022-09-27 11:43:53 +00:00
6543 commented 2022-09-27 11:45:28 +00:00
Author
Owner
Copy Link

#515 (comment)

screenshot updated ;)

https://gitea.com/gitea/tea/pulls/515#issuecomment-718188 screenshot updated ;)
6543 added 1 commit 2022-09-27 15:40:57 +00:00
Merge branch 'main' into handle_team-reviews
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e26aed9f9e
wxiaoguang reviewed 2022-09-28 02:20:41 +00:00
modules/print/pull.go Outdated
@ -108,0 +109,4 @@
}
} else if review.ReviewerTeam != nil {
if r, ok := reviewByUserOrTeam[review.ReviewerTeam.Name]; !ok || review.Submitted.After(r.Submitted) {
reviewByUserOrTeam[review.ReviewerTeam.Name] = review
wxiaoguang commented 2022-09-28 02:20:41 +00:00
Member
Copy Link

What if the team name conflicts with user name?

What if the team name conflicts with user name?
👍 1
6543 marked this conversation as resolved
6543 added 1 commit 2022-09-29 00:29:05 +00:00
use uniqe IDs for sure
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ef2b0c3214
6543 commented 2022-09-29 00:29:20 +00:00
Author
Owner
Copy Link

@wxiaoguang done

@wxiaoguang done
wxiaoguang approved these changes 2022-09-29 02:07:14 +00:00
6543 merged commit c1c7870ceb into main 2022-09-29 02:49:24 +00:00
6543 deleted branch handle_team-reviews 2022-09-29 02:49:24 +00:00
6543 referenced this issue from a commit 2022-09-29 02:49:25 +00:00
Handle Team Reviews (#515)
Sign in to join this conversation.
Reviewers
No reviewers
noerw
wxiaoguang
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.10.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#515
No description provided.
Delete Branch "6543/tea:handle_team-reviews"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?