gitea/tea
gitea/tea
57
135
Fork 67
Code Issues 102 Pull Requests 8 Actions Releases 16 Activity

Print pull dont crash if it has TeamReviewRequests #517

Merged
6543 merged 1 commits from 6543/tea:backport_nil-team-review-err into release/v0.9 2022-09-29 12:35:57 +00:00
Conversation 0 Commits 1 Files Changed 1 +5 -2
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/print/pull.go
View File

@ -99,8 +99,11 @@ func formatReviews(reviews []*gitea.PullReview) string {
case gitea.ReviewStateApproved,
gitea.ReviewStateRequestChanges,
gitea.ReviewStateRequestReview:
if r, ok := reviewByUser[review.Reviewer.ID]; !ok || review.Submitted.After(r.Submitted) {
reviewByUser[review.Reviewer.ID] = review
// only user reviews are supported no team review requests
if review.Reviewer != nil {
if r, ok := reviewByUser[review.Reviewer.ID]; !ok || review.Submitted.After(r.Submitted) {
reviewByUser[review.Reviewer.ID] = review
}
}
}
}