gitea/tea
gitea/tea
58
136
Fork 67
Code Issues 104 Pull Requests 8 Actions Releases 16 Activity

Fix for go tools called from make #568

Merged
6543 merged 9 commits from :toolsfix into main 2023-08-21 22:01:17 +00:00
Conversation 5 Commits 9 Files Changed 2 +8 -7
RivenSkaye commented 2023-07-28 12:11:24 +00:00
Contributor
Copy Link

Fixes #567 by offloading the $PATH interpolation to the shell instead of letting make handle it.
Tested and works on Linux, tested and works on Windows using MSYS2/MingW64. Not tested on a pure Windows env without translation layers, but nothing was changed that would actively break it either.

Fixes #567 by offloading the `$PATH` interpolation to the shell instead of letting make handle it. Tested and works on Linux, tested and works on Windows using MSYS2/MingW64. Not tested on a pure Windows env without translation layers, but nothing was changed that would actively break it either.
👍 1 ❤️ 1
RivenSkaye added 1 commit 2023-07-28 12:11:28 +00:00
simple fix for go tools
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 53s
Details
0cfab84c08 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
lunny approved these changes 2023-07-29 13:24:19 +00:00
RivenSkaye commented 2023-07-29 13:53:36 +00:00
Author
Contributor
Copy Link

RE: #567 (comment)
@jolheiser the makefile for gitea works, but it would imply forcing updates of the selected tool versions whenever available. If that's desirable, I'll commit that instead and see if removing the $PATH change altogether works while I'm at it since it makes the entire line redundant

RE: https://gitea.com/gitea/tea/issues/567#issuecomment-746285 @jolheiser the makefile for gitea works, but it would imply forcing updates of the selected tool versions whenever available. If that's desirable, I'll commit that instead and see if removing the `$PATH` change altogether works while I'm at it since it makes the entire line redundant
jolheiser commented 2023-07-29 21:38:19 +00:00
Owner
Copy Link

it would imply forcing updates of the selected tool versions whenever available.

The referenced makefile runs the tools at those exact versions, which theoretically means it should be more consistent than it currently is because

Makefile Line 149 in 77837e909e
@hash revive > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
means if the user has any version installed, it "passes" this check, even if the version is different.

Unless I'm misunderstanding what you said.

> it would imply forcing updates of the selected tool versions whenever available. The referenced makefile runs the tools at those _exact_ versions, which theoretically means it should be _more_ consistent than it currently is because https://gitea.com/gitea/tea/src/commit/77837e909ef4822b06c475160f9e8dcc693d3393/Makefile#L149 means if the user has any version installed, it "passes" this check, even if the version is different. Unless I'm misunderstanding what you said.
RivenSkaye commented 2023-07-30 10:22:03 +00:00
Author
Contributor
Copy Link

if the user has any version installed, it "passes" this check

I'm not too familiar with the Go toolchain, and I'd expect go run x@latest to always download and run the latest version available upstream for a package. Even if any locally available version satisfies that dependency, I'd expect it to still have that effect on CI runners that start in a clean env on every build.

Please do tell me if I'm wrong. I'll see if I have the time to edit and run the proposed changes later today or somewhere this evening on a clean env

> if the user has any version installed, it "passes" this check I'm not _too_ familiar with the Go toolchain, and I'd expect `go run x@latest` to always download and run the latest version available upstream for a package. Even if any locally available version satisfies that dependency, I'd expect it to still have that effect on CI runners that start in a clean env on every build. Please do tell me if I'm wrong. I'll see if I have the time to edit and run the proposed changes later today or somewhere this evening on a clean env
jolheiser commented 2023-07-30 15:50:27 +00:00
Owner
Copy Link

You're correct, which is why the referenced Makefile in the main repo pins the version, so that everyone runs the same pinned version rather than @latest

You're correct, which is why the referenced Makefile in the main repo pins the version, so that everyone runs the same pinned version rather than `@latest`
RivenSkaye added 1 commit 2023-08-21 06:40:29 +00:00
simple fix for go tools
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 53s
Details
836dd726e7 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
RivenSkaye added 1 commit 2023-08-21 06:42:30 +00:00
Remove shell offloading as requested
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 48s
Details
a1a0a213d7
RivenSkaye added 1 commit 2023-08-21 06:53:00 +00:00
attempt to fix module path error
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 48s
Details
319ef2f070 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
RivenSkaye added 2 commits 2023-08-21 07:06:32 +00:00 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
Merge branch 'gitea-main' into toolsfix
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 46s
Details
bfaf32edd1 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
RivenSkaye added 1 commit 2023-08-21 07:18:43 +00:00
Accidentally broke checking for gitea-vim without extension
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 48s
Details
2e99a21c05 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
RivenSkaye force-pushed toolsfix from 2e99a21c05 to 299be090a0 2023-08-21 07:21:40 +00:00 Compare
RivenSkaye added 1 commit 2023-08-21 07:22:59 +00:00
Forgot one misspell call
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 48s
Details
273f848277 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
RivenSkaye added 1 commit 2023-08-21 07:26:13 +00:00
Missed a section for the package
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 1m41s
Details
c7901b5c6f 
Signed-off-by: Martin Veldwijk <riven@tae.moe>
RivenSkaye commented 2023-08-21 07:29:28 +00:00
Author
Contributor
Copy Link

Sorry for letting this sit for a while. Had a little while off and forgot some things at the office.

Tested this to work on my local env, on a clean env and it passes the CI runs. Unless there are any concerns, this looks fine to me

Sorry for letting this sit for a while. Had a little while off and forgot some things at the office. Tested this to work on my local env, on a clean env and it passes the CI runs. Unless there are any concerns, this looks fine to me
6543 approved these changes 2023-08-21 22:01:02 +00:00
6543 merged commit e4e8eb07d2 into main 2023-08-21 22:01:17 +00:00
6543 added the
kind/bug
kind/build
 labels 2023-08-21 22:01:29 +00:00
6543 added this to the v0.10.0 milestone 2023-08-21 22:01:36 +00:00
RivenSkaye deleted branch toolsfix 2024-07-22 13:34:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
6543
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.10.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#568
No description provided.
Delete Branch ":toolsfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?