Narrow body with and align gitea icon #126

Merged
silverwind merged 5 commits from pat-s/theme:blog-body into main 2023-04-29 07:41:20 +00:00
Member

As discussed in the maintainers channel.

Screenshots

image

image

image

As discussed in the maintainers channel. ## Screenshots ![image](/attachments/64fd58d9-fbbf-4adf-bd56-13d7b2c8f197) ![image](/attachments/d08b4367-9cc5-4faf-b55d-1c3d5940f20a) ![image](/attachments/c3ab77e9-4b12-463e-9846-8a624ba750d2)
pat-s added 2 commits 2023-04-22 19:01:40 +00:00
Some checks failed
dry run building theme / dry-run (pull_request) Has been cancelled
a23a9ab64c
use content instead of section
pat-s added 1 commit 2023-04-22 19:33:36 +00:00
Some checks failed
dry run building theme / dry-run (pull_request) Has been cancelled
db34d7bdce
fix page card display
pat-s changed title from WIP: narrow body with and align gitea icon to Narrow body with and align gitea icon 2023-04-22 19:33:59 +00:00
silverwind reviewed 2023-04-22 19:59:21 +00:00
src/main.scss Outdated
@ -68,3 +68,3 @@
.navbar .navbar-brand {
align-items: center;
justify-content: space-between;
justify-content: end;

Shouldn't this be flex-end, assuming it's a flexbox?

Shouldn't this be `flex-end`, assuming it's a flexbox?
silverwind marked this conversation as resolved
silverwind reviewed 2023-04-22 20:00:55 +00:00
@ -307,0 +312,4 @@
margin: 0 auto;
}
.tabs:not(:last-child), .message:not(:last-child), .list:not(:last-child), .level:not(:last-child), .breadcrumb:not(:last-child), .highlight:not(:last-child), .block:not(:last-child), .title:not(:last-child), .subtitle:not(:last-child), .table-container:not(:last-child), .table:not(:last-child), .progress:not(:last-child), .notification:not(:last-child), .content:not(:last-child), .box:not(:last-child) {

So many selectors and all of them with not, surely there must be a better way, e.g. invert the matching and match only what you want to match. Generally I think every not case in CSS should be refactored to not use it.

So many selectors and all of them with `not`, surely there must be a better way, e.g. invert the matching and match only what you want to match. Generally I think every `not` case in CSS should be refactored to not use it.

Maybe use gap property, e.g. when it's a flexbox:

.tabs {
  gap: 6px
}
Maybe use `gap` property, e.g. when it's a flexbox: ```css .tabs { gap: 6px }
Author
Member

Could very well be, I am not an expert in CSS. Just trying to get to what I want using the browser selector and some trial&error 😅

So every suggestion is welcome!

Could very well be, I am not an expert in CSS. Just trying to get to what I want using the browser selector and some trial&error 😅 So every suggestion is welcome!

If above does not work, :is() should be able to reduce the size of this selector. But I still see that as a non-ideal solution 😜.

If above does not work, [:is()](https://developer.mozilla.org/en-US/docs/Web/CSS/:is) should be able to reduce the size of this selector. But I still see that as a non-ideal solution 😜.
Author
Member

gap cannot be used because of display: block.

The large selector comes from a node dependency named bulma - it is not defined in our theme.

I've now found a way by adding it to .content directly and things still look as desired. Is that better?

`gap` cannot be used because of `display: block`. The large selector comes from a node dependency named `bulma` - it is not defined in our theme. I've now found a way by adding it to `.content` directly and things still look as desired. Is that better?

Yes, looks much cleaner now.

Yes, looks much cleaner now.
silverwind marked this conversation as resolved
pat-s added 2 commits 2023-04-24 06:48:02 +00:00
All checks were successful
dry run building theme / dry-run (pull_request) Successful in 51s
0563b98614
optimize content padding definition
silverwind approved these changes 2023-04-27 09:28:43 +00:00
Member

BTW, what is this status and how can we get a CI run again?

image

BTW, what is this status and how can we get a CI run again? ![image](/attachments/20eec4e0-730c-4bc5-924e-349557b03b36)
lunny approved these changes 2023-04-29 00:22:56 +00:00
silverwind merged commit 9036d486c2 into main 2023-04-29 07:41:20 +00:00
pat-s deleted branch blog-body 2023-04-29 14:44:48 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.