gitea/website
Archived
44
15
Fork 17
Code Issues 1 Pull Requests 1 Actions Releases Wiki Activity

Add link to try.gitea.io #17

Closed
strk wants to merge 4 commits from unknown repository into main
pull from: unknown repository
merge into: gitea:main
Conversation 12 Commits 4 Files Changed 1 +14 -2
strk commented 2016-12-14 14:05:12 +00:00 (Migrated from github.com)
Copy Link

.. also mention planned self-hosting and add link to download area

.. also mention planned self-hosting and add link to download area
lunny commented 2016-12-14 15:16:27 +00:00
Copy Link

LGTM

LGTM
tboerger commented 2016-12-14 15:24:21 +00:00 (Migrated from github.com)
Copy Link

Generally I prefer lesser new lines as all the single sentences will be transferred to separate paragraphs.

Generally I prefer lesser new lines as all the single sentences will be transferred to separate paragraphs.
strk commented 2016-12-14 15:26:40 +00:00 (Migrated from github.com)
Copy Link

Given the amount of current content, it isn't bad to have more paragraphs..

Given the amount of current content, it isn't bad to have more paragraphs..
tboerger commented 2016-12-14 16:15:45 +00:00 (Migrated from github.com)
Copy Link

Instead of stretching simple phrases we want things like screenshots.

Instead of stretching simple phrases we want things like screenshots.
strk commented 2016-12-14 16:44:44 +00:00 (Migrated from github.com)
Copy Link

I think we can do better incrementally, how about merging this and
sending a new PR for next iteration ?

I think we can do better incrementally, how about merging this and sending a new PR for next iteration ?
bkcsoft commented 2016-12-19 17:46:19 +00:00 (Migrated from github.com)
Copy Link

I would flip the 2 lower around and then put them in the same paragraph.

I would flip the 2 lower around and then put them in the same paragraph.
tboerger commented 2016-12-19 18:43:49 +00:00 (Migrated from github.com)
Copy Link

👎 stop the line wrapping.

:-1: stop the line wrapping.
strk commented 2016-12-19 18:49:41 +00:00 (Migrated from github.com)
Copy Link

How do line wrapping hurt ?
What does your -1 mean in terms of acceptability of this PR ?
The CONTRIBUTING.md file doesn't mention veto powers nor does
go into details of acceptance/rejection (it probably should)

How do line wrapping hurt ? What does your -1 mean in terms of acceptability of this PR ? The CONTRIBUTING.md file doesn't mention veto powers nor does go into details of acceptance/rejection (it probably should)
lunny commented 2016-12-20 01:12:51 +00:00
Copy Link

All are right except line wrapping. It will break the UI on mobile or other small screen devices.

All are right except line wrapping. It will break the UI on mobile or other small screen devices.
strk commented 2016-12-20 09:46:39 +00:00 (Migrated from github.com)
Copy Link

On Mon, Dec 19, 2016 at 05:12:51PM -0800, Lunny Xiao wrote:

All are right except line wrapping. It will break the UI on mobile or other small screen devices.

Single linebreaks in markdown have no structural meaning and should
thus not change the rendered output in any way. Do you have proof of
your statement about breaking on mobile UI and small screen devices ?

On Mon, Dec 19, 2016 at 05:12:51PM -0800, Lunny Xiao wrote: > All are right except line wrapping. It will break the UI on mobile or other small screen devices. Single linebreaks in markdown have no structural meaning and should thus not change the rendered output in any way. Do you have proof of your statement about breaking on mobile UI and small screen devices ?
tboerger commented 2016-12-20 17:26:24 +00:00 (Migrated from github.com)
Copy Link

Just revert the line breaks to match the style of ALL other markdown documents. Without this revert I'm against this pr.

Just revert the line breaks to match the style of ALL other markdown documents. Without this revert I'm against this pr.
strk commented 2016-12-24 14:18:26 +00:00 (Migrated from github.com)
Copy Link

Not needed anymore now, there's a big green TRY button now..

Not needed anymore now, there's a big green TRY button now..
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/website#17
No description provided.
Delete Branch "unknown repository"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?