gitea/website
Archived
44
15
Fork 17
Code Issues 1 Pull Requests 1 Actions Releases Wiki Activity

Register themes/gitea submodule #2

Closed
strk wants to merge 2 commits from unknown repository into main
pull from: unknown repository
merge into: gitea:main
Conversation 9 Commits 2 Files Changed 3 +4 -1
strk commented 2016-11-10 10:41:35 +00:00 (Migrated from github.com)
Copy Link

I think it helps, will leave decision to others

I think it helps, will leave decision to others
andreynering commented 2016-11-10 10:44:19 +00:00 (Migrated from github.com)
Copy Link

Maybe subtree?

Maybe subtree?
strk commented 2016-11-10 10:48:14 +00:00 (Migrated from github.com)
Copy Link

Why subtree ? Submodule only drops a reference to the SHA and the repository public URL in the main repository. I don't know what subtree does.

Why subtree ? Submodule only drops a reference to the SHA and the repository public URL in the main repository. I don't know what subtree does.
andreynering commented 2016-11-10 10:53:40 +00:00 (Migrated from github.com)
Copy Link

I was just thinking... I would be a kind of vendoring, a PR would need to be open every time one want to update the theme. Maybe submodules are better if we want it automatically updated. Let's @tboerger decide this.

I was just thinking... I would be a kind of vendoring, a PR would need to be open every time one want to update the theme. Maybe submodules are better if we want it automatically updated. Let's @tboerger decide this.
tboerger commented 2016-11-10 11:23:08 +00:00 (Migrated from github.com)
Copy Link

Simply NO! This won't work with an automated workflow. I have already created PRs to add a make task and it's also documented. So here a BIG -1 from my side.

Simply NO! This won't work with an automated workflow. I have already created PRs to add a make task and it's also documented. So here a BIG -1 from my side.
strk commented 2016-11-10 11:26:25 +00:00 (Migrated from github.com)
Copy Link

On Thu, Nov 10, 2016 at 03:23:08AM -0800, Thomas Boerger wrote:

Simply NO! This won't work with an automated workflow. I have already created PRs to add a make task and it's also documented. So here a BIG -1 from my side.

I suspected your veto.
Anyway "won't work with automated workflow" is not true...

On Thu, Nov 10, 2016 at 03:23:08AM -0800, Thomas Boerger wrote: > Simply NO! This won't work with an automated workflow. I have already created PRs to add a make task and it's also documented. So here a BIG -1 from my side. I suspected your veto. Anyway "won't work with automated workflow" is not true...
tboerger commented 2016-11-10 11:28:45 +00:00 (Migrated from github.com)
Copy Link

It won't work unless you allow the CI to push changes, and this is nothing I would even consider if I compare it with the current setup.

It won't work unless you allow the CI to push changes, and this is nothing I would even consider if I compare it with the current setup.
strk commented 2016-11-10 11:58:13 +00:00 (Migrated from github.com)
Copy Link

@tboerger the current setup doesn't push any changes, just adds a 'git' command and clones a repository. Both thing that with the setup in the PR are not needed

@tboerger the current setup doesn't push any changes, just adds a 'git' command and clones a repository. Both thing that with the setup in the PR are not needed
metalmatze commented 2016-11-10 12:21:43 +00:00 (Migrated from github.com)
Copy Link

A No from me as well.
Submodules need to be updated to update the theme, the current pipeline that was setup by @tboerger is way superior. We really don't need submodules.
I suggest to add a Makefile and in make all it pulls everything to get one started locally.

A _No_ from me as well. Submodules need to be updated to update the theme, the current pipeline that was setup by @tboerger is way superior. We really don't need submodules. I suggest to add a `Makefile` and in `make all` it pulls everything to get one started locally.
strk commented 2016-11-10 12:28:46 +00:00 (Migrated from github.com)
Copy Link

Ok then. Makefile was added by @tboerger, waiting for lgtm in #3

Ok then. Makefile was added by @tboerger, waiting for lgtm in #3
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/website#2
No description provided.
Delete Branch "unknown repository"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?