[Pull] Crowdin [2020-03-11] #277

New Issue

Closed

opened 2020-06-04 00:42:26 +00:00 by 6543 · 5 comments

6543 commented

2020-06-04 00:42:26 +00:00

Member

update from crowdin

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/277

Merged with: 26429ca6e7

update from crowdin --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/277 Merged with: 26429ca6e796efc6cebb795774236fb16d75db09

6543 added this to the 2.4.0 milestone 2020-06-04 00:42:26 +00:00

6543 added the

🌐 Translation

label 2020-06-04 00:42:26 +00:00

6543 closed this issue

2020-06-04 00:42:26 +00:00

mmarif commented

2020-06-04 00:43:06 +00:00

Owner

Commented on few strings to fix. Others looks good to go.

6543 commented

2020-06-04 00:43:26 +00:00

Author

Member

@mmarif cant find your comments

mmarif commented

2020-06-04 00:43:47 +00:00

Owner

@6543 weird. Maybe Gitea permission issue?

Here are the things to fix:
file is values-fa/strings.xml

Line 65, 66, 67 (see the screenshot for details)

Line 154, 166 and 167 has broken string in values-fa/strings.xml. %1$s is broken.

@6543 weird. Maybe Gitea permission issue? Here are the things to fix: file is `values-fa/strings.xml` Line 65, 66, 67 (see the screenshot for details) Line 154, 166 and 167 has broken string in values-fa/strings.xml. %1$s is broken.

6543 commented

2020-06-04 00:44:07 +00:00

Author

Member

@mmarif this is a "pending" comment you have to finish the review

mmarif commented

2020-06-04 00:44:27 +00:00

Owner

this is a “pending” comment you have to finish the review

Just a thought, if adding code comments/review the Request Changes button should be visible to let the user know to submit the comments.

> this is a “pending” comment you have to finish the review Just a thought, if adding code comments/review the `Request Changes` button should be visible to let the user know to submit the comments.