[New] Notifications #5

New Issue

Closed

opened 2020-06-03 13:10:52 +00:00 by mmarif · 15 comments

mmarif commented

2020-06-03 13:10:52 +00:00

Owner

This is dependent on Gitea API. Right now there is no API for it.

mmarif added this to the 3.0.0 milestone 2020-06-03 13:10:52 +00:00

mmarif added the

🎉 Feature

label 2020-06-03 13:10:52 +00:00

6543 commented

2020-06-03 13:11:33 +00:00

Member

Created By: @lunny

Please send a feature request issue to gitea.

Created By: @lunny Please send a feature request issue to gitea.

mmarif commented

2020-06-03 13:11:53 +00:00

Author

Owner

Older issue I found for this, https://github.com/go-gitea/gitea/issues/4811

6543 commented

2020-06-03 13:12:13 +00:00

Member

https://developer.android.com/guide/topics/ui/notifiers/notifications ... hmm

check updates ...

... by pull

intervall should be set or depend on battery condition
battery hungry if intervall is short

... by push (FCM)

use Google Cloud Messaging ...
- relay on Google :(
- propretair code
- tracking
save battery
get notifications when they hapen
need Google Play Services !!!

... by push (own)

gitea has to be a push provider too :(
save battery
get notifications when they hapen
implement alot again F-Droid: replacing gcm in tutanota

-> do it the pull way?

https://developer.android.com/guide/topics/ui/notifiers/notifications ... hmm ## check updates ... ### ... by pull * intervall should be set or depend on battery condition * battery hungry if intervall is short ### ... by push (FCM) * use Google Cloud Messaging ... - relay on Google :( - propretair code - tracking * save battery * get notifications when they hapen * need Google Play Services !!! ### ... by push (own) * gitea has to be a push provider too :( * save battery * get notifications when they hapen * implement alot again [F-Droid: replacing gcm in tutanota](https://f-droid.org/de/2018/09/03/replacing-gcm-in-tutanota.html) ## -> do it the pull way?

mmarif commented

2020-06-03 13:12:33 +00:00

Author

Owner

Thanks @6543.

I try to avoid FCM and any google related implementation. Otherwise I have to handle two different versions of the app for gplay and f-droid.

Other than that, if Gitea implement a push service. Will be nice, but I am not sure it will happen in near future.

There is an app for fediverse(Fedilab), I work with the developer as UX and he implemented notifications I guess without FCM(Google). It will be more work but good for future. And notifications will be not instant, but surely a little delay will not harm though.

So yeah, pull way is the only way to go with. But still have time to do this, so let's wait and see how the things will turn out.

Thanks @6543. I try to avoid FCM and any google related implementation. Otherwise I have to handle two different versions of the app for gplay and f-droid. Other than that, if Gitea implement a push service. Will be nice, but I am not sure it will happen in near future. There is an app for fediverse(Fedilab), I work with the developer as UX and he implemented notifications I guess without FCM(Google). It will be more work but good for future. And notifications will be not instant, but surely a little delay will not harm though. So yeah, pull way is the only way to go with. But still have time to do this, so let's wait and see how the things will turn out.

6543 commented

2020-06-03 13:12:53 +00:00

Member

@mmarif -> https://github.com/go-gitea/gitea/pull/9488 🎉

@mmarif -> https://github.com/go-gitea/gitea/pull/9488 :tada:

mmarif commented

2020-06-03 13:13:13 +00:00

Author

Owner

Wish it was part of 1.11 release. Is 1.11 in freeze?

This PR if completed can be part of it.

Wish it was part of 1.11 release. Is 1.11 in freeze? This PR if completed can be part of it.

6543 commented

2020-06-03 13:13:33 +00:00

Member

NO 1.11 is in freeze -> we will get notification support with gitea 1.12

and I also send a extend for mobile clienst: https://github.com/go-gitea/gitea/pull/9595

@mmarif at this point only realy needed features can go into 1.11 (the owners + maintainers must be for it ...)

NO 1.11 is in freeze -> we will get notification support with gitea 1.12 and I also send a extend for mobile clienst: https://github.com/go-gitea/gitea/pull/9595 @mmarif at this point only realy needed features can go into 1.11 (the owners + maintainers must be for it ...)

mmarif commented

2020-06-03 13:13:53 +00:00

Author

Owner

Then it makes sense if it is feature freeze.

Looking forward to this PR. One of the feature users will love it.

Then it makes sense if it is feature freeze. Looking forward to this PR. One of the feature users will love it.

6543 commented

2020-06-03 13:14:14 +00:00

Member

PR is merged! Gitea >= 1.12.0 will support this api

6543 commented

2020-06-03 13:14:34 +00:00

Member

https://github.com/go-gitea/gitea/pull/9595 is merged now

so we have a api endpoint to check if app should show new notifications!

GET /notifications/new

and the default github notification-api to manage the rest ...

https://github.com/go-gitea/gitea/pull/9595 is merged now so we have a api endpoint to check if app should show new notifications! * `GET /notifications/new` and the default github notification-api to manage the rest ...

mmarif commented

2020-06-03 13:14:54 +00:00

Author

Owner

@6543 This is great. Thank you for the awesome work. 👍

@6543 This is great. Thank you for the awesome work. :thumbsup:

6543 commented

2020-06-03 13:15:14 +00:00

Member

as @opyale mentioned its worth to have a look at https://developer.android.com/topic/libraries/architecture/workmanager/

and we should keep track of https://github.com/go-gitea/gitea/pull/10884 since it enable Web Push witch we perhaps could use in some way?

as @opyale mentioned its worth to have a look at https://developer.android.com/topic/libraries/architecture/workmanager/ and we should keep track of https://github.com/go-gitea/gitea/pull/10884 since it enable **Web Push** witch we perhaps could use in some way?

mmarif commented

2020-06-03 13:15:34 +00:00

Author

Owner

Web push may not work unless we use webview in the app kinda of think about Electron app on desktop.

Yes, workmanager is a good link.

Just one thing we need to make sure is to not use anything related to Google data saving like firebase(GCM) etc because we can't keep two separate apps for play store and f-droid. Also the core of this app is to be privacy friendly.

Any ideas which does not touch that ground are always welcome.

Web push may not work unless we use webview in the app kinda of think about Electron app on desktop. Yes, workmanager is a good link. Just one thing we need to make sure is to not use anything related to Google data saving like firebase(GCM) etc because we can't keep two separate apps for play store and f-droid. Also the core of this app is to be privacy friendly. Any ideas which does not touch that ground are always welcome.