[Pull] Milestones filter(open/close) + refactor #506

New issue

Closed

opened 2020-06-04 06:46:32 +00:00 by mmarif · 5 comments

mmarif commented

2020-06-04 06:46:32 +00:00

Owner

Closes #384

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/506

Merged with: b30e2da387

Closes #384 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/506 Merged with: b30e2da3879488986d0adfb2644d3783ea1119a9

mmarif added this to the 3.0.0 milestone 2020-06-04 06:46:32 +00:00

mmarif added the

🎯 Enhancement

🪒 Refactor

labels 2020-06-04 06:46:32 +00:00

mmarif closed this issue

2020-06-04 06:46:32 +00:00

mmarif was assigned by 6543

2020-06-04 06:47:13 +00:00

6543 commented

2020-06-04 06:47:13 +00:00

Member

@mmarif I think this is the wrong way arround, it will delete all related translations & to open vs is open have different translations - I'll push aa commit ...

@mmarif I think this is the wrong way arround, it will delete all related translations & `to open` vs `is open` have different translations - I'll push aa commit ...

mmarif commented

2020-06-04 06:47:33 +00:00

Author

Owner

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?

6543 commented

2020-06-04 06:47:53 +00:00

Member

@mmarif in German language its a question between öffnen and Offen

@mmarif in German language its a question between `öffnen` and `Offen`

mmarif commented

2020-06-04 06:48:13 +00:00

Author

Owner

in German language its a question between öffnen and Offen

Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed).

The removed strings are not used anywhere in the app.

You can propse a change via commit if you think it need to be corrected.

> in German language its a question between öffnen and Offen Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed). The removed strings are not used anywhere in the app. You can propse a change via commit if you think it need to be corrected.

mmarif commented

2020-06-04 06:48:33 +00:00

Author

Owner

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.

mmarif referenced this issue from a commit

2020-06-21 09:53:37 +00:00

Milestones filter(open/close) + refactor (#506) remove strings translation: generic but with contecxt Merge branch 'milestones-filter' of gitea.com:gitnex/GitNex into milestones-filter Clean up strings Merge branch 'master' into milestones-filter clean up and add missing parts enhance and refactor milestone, added filter for closed and open ms change to viewbinding Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/506 Reviewed-by: 6543 <6543@noreply.gitea.io>