gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Fix creating multiple tokens #202

Manually merged
mmarif merged 1 commits from 119-app-tokens into master 2019-11-16 05:18:43 +00:00
Conversation 2 Commits 1 Files Changed 3 +35 -5
mmarif commented 2019-11-15 19:42:55 +00:00
Owner
Copy Link

The changes were made in the upstream API of tokens, where sha1 does not have token anymore. Instead token_last_eight is added. Adjusted the code base to these new changes including work around for older versions which still use sha1.

Will close #119

The changes were made in the upstream API of tokens, where sha1 does not have token anymore. Instead `token_last_eight` is added. Adjusted the code base to these new changes including work around for older versions which still use sha1. Will close #119
mmarif added this to the 2.3.0 milestone 2019-11-15 19:42:55 +00:00
mmarif added the
Refactor
Improvement
 labels 2019-11-15 19:42:55 +00:00
mmarif self-assigned this 2019-11-15 19:42:56 +00:00
mmarif added the
LGTM-need
 label 2019-11-15 19:44:19 +00:00
6543 approved these changes 2019-11-16 01:56:41 +00:00
Dismissed
6543 left a comment
Member

ok

ok
6543 added
LGTM-done
 and removed
LGTM-need
 labels 2019-11-16 01:56:51 +00:00
6543 commented 2019-11-16 02:06:11 +00:00
Member
Copy Link

nice this works as expected ... only if you deinstall&install the app a new token is created (with an different id)

nice this works as expected ... only if you deinstall&install the app a new token is created (with an different id)
mmarif commented 2019-11-16 04:46:57 +00:00
Author
Owner
Copy Link

Reinstall is not required, logout and login will work.

Reinstall is not required, logout and login will work.
mmarif closed this pull request 2019-11-16 05:18:43 +00:00
mmarif closed this pull request 2019-11-16 05:18:43 +00:00
mmarif deleted branch 119-app-tokens 2019-11-16 05:18:54 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.3.0
Assignees
Clear assignees
No Assignees
mmarif
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#202
No description provided.
Delete Branch "119-app-tokens"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?