Merge pull request #210

mmarif · 2019-11-25T14:22:23Z

mmarif commented

2019-11-25 14:22:23 +00:00

Will close #10

mmarif added this to the 2.3.0 milestone 2019-11-25 14:22:23 +00:00

mmarif added the

Feature

label 2019-11-25 14:22:23 +00:00

mmarif self-assigned this 2019-11-25 14:22:23 +00:00

mmarif changed title from ~~Merge pull request~~ to [WIP] Merge pull request

2019-11-25 14:26:35 +00:00

mmarif added the

LGTM-need

label 2019-11-27 15:12:23 +00:00

mmarif commented

2019-11-27 15:12:48 +00:00

@6543 It's ready to test!

mmarif changed title from ~~[WIP] Merge pull request~~ to Merge pull request

2019-11-27 15:13:01 +00:00

6543 approved these changes 2019-11-27 16:48:01 +00:00

Dismissed

6543 left a comment

see #212
otherwise lgtm

see #212 otherwise lgtm

6543 added

LGTM-done

and removed

LGTM-need

labels 2019-11-27 16:48:15 +00:00

6543 commented

2019-11-27 16:50:28 +00:00

@mmarif:

AndroidManifest has some useles changes ... thing the IDE has its fingers on the file ...
#212

@mmarif: * AndroidManifest has some useles changes ... thing the IDE has its fingers on the file ... * #212

6543 commented

2019-11-27 16:51:05 +00:00

note for me: 6strings for translation added ...

mmarif commented

2019-11-27 17:02:52 +00:00

@6543 Yes, when new activity is added, it do a little bit of reshuffle, but nothing to worry about.

mmarif closed this pull request

2019-11-27 17:03:51 +00:00

mmarif deleted branch 10-merge-pr

2019-11-27 17:04:00 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

Priority-high

Accepting-merge-requests

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#210