gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Switch to bottomsheets for popup menus #333

Merged
mmarif merged 3 commits from 304-popup-menus-to-bottomsheets into master 2020-04-02 08:06:00 +00:00
Conversation 4 Commits 3 Files Changed 13 +439 -459
mmarif commented 2020-04-01 06:41:04 +00:00
Owner
Copy Link

Closes #304

Closes #304
mmarif added this to the 2.5.0 milestone 2020-04-01 06:41:04 +00:00
mmarif added the
Enhancement
WIP
 labels 2020-04-01 06:41:04 +00:00
mmarif self-assigned this 2020-04-01 06:41:04 +00:00
mmarif commented 2020-04-01 06:43:00 +00:00
Author
Owner
Copy Link

This looks way better than annoying popups. :)

This looks way better than annoying popups. :)
Screenshot_20200401_114209.png
44 KiB
Screenshot_20200401_114209.png
mmarif added
LGTM-need
 and removed
WIP
 labels 2020-04-01 09:47:12 +00:00
mmarif commented 2020-04-01 09:47:34 +00:00
Author
Owner
Copy Link

Please let me know if I missed any.

Please let me know if I missed any.
6543 commented 2020-04-01 22:47:04 +00:00
Member
Copy Link

after this "Delete Comment" and "Share Comment" easely fit into the UI
(#165, #339)

after this "Delete Comment" and "Share Comment" easely fit into the UI (#165, #339)
6543 approved these changes 2020-04-01 22:52:35 +00:00
Dismissed
6543 left a comment
Member

looked throu the code + tested

looked throu the code + tested
6543 added
LGTM-done
UI/UX
 and removed
LGTM-need
 labels 2020-04-01 22:52:57 +00:00
mmarif commented 2020-04-02 08:05:41 +00:00
Author
Owner
Copy Link

after this “Delete Comment” and “Share Comment” easely fit into the UI

That would be next.

> after this “Delete Comment” and “Share Comment” easely fit into the UI That would be next.
mmarif closed this pull request 2020-04-02 08:06:00 +00:00
mmarif deleted branch 304-popup-menus-to-bottomsheets 2020-04-02 08:06:16 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.5.0
Assignees
Clear assignees
No Assignees
mmarif
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#333
No description provided.
Delete Branch "304-popup-menus-to-bottomsheets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?