gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

[UI] Add Pull & Release Counter Badge to TabLable #350

Merged
mmarif merged 10 commits from 6543/GitNex:218-PR-Tab_OpenNumber into master 2020-04-04 19:20:30 +00:00
Conversation 6 Commits 10 Files Changed 11 +424 -327
6543 commented 2020-04-04 01:38:44 +00:00
Member
Copy Link
* close #218 | [Extend] Pull Request Tab: show open number * [Extend] Release Request Tab: show open number API has bug in master -> https://github.com/go-gitea/gitea/issues/10946 * Upgrade Gradle and a nit
6543 added this to the 2.5.0 milestone 2020-04-04 01:38:44 +00:00
6543 added the
Enhancement
UI/UX
LGTM-need
 labels 2020-04-04 01:38:44 +00:00
mmarif reviewed 2020-04-04 12:17:30 +00:00
Dismissed
app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java Outdated
@ -134,3 +145,1 @@
@SuppressLint("InflateParams") View tabHeader = LayoutInflater.from(this).inflate(R.layout.badge, null);
textViewBadge = tabHeader.findViewById(R.id.counterBadge);
if(!tinyDb.getString("issuesCounter").isEmpty()) {
//if(!tinyDb.getString("issuesCounter").isEmpty()) {
mmarif commented 2020-04-04 12:17:17 +00:00
Owner

No idea where is this value set?

No idea where is this value set?
6543 commented 2020-04-04 14:20:51 +00:00
Author
Member

It was there before ...

It was there before ...
mmarif commented 2020-04-04 12:19:23 +00:00
Owner
Copy Link

tinyDb.getString("issuesCounter").isEmpty() don't know where is this set. So I disabled it for now as it counter will not work if this is enabled while switching from settings.

`tinyDb.getString("issuesCounter").isEmpty()` don't know where is this set. So I disabled it for now as it counter will not work if this is enabled while switching from settings.
6543 commented 2020-04-04 14:22:00 +00:00
Author
Member
Copy Link

@mmarif a code search show it is only used in this Line so I'll remove it ...

@mmarif a code search show it is only used in this Line so I'll remove it ...
6543 commented 2020-04-04 14:23:25 +00:00
Author
Member
Copy Link

DONE

DONE
6543 commented 2020-04-04 15:58:56 +00:00
Author
Member
Copy Link

ok after your changes it stoped working - I'll look into it why it doesnt work anymore

ok after your changes it stoped working - I'll look into it why it doesnt work anymore
mmarif commented 2020-04-04 16:01:23 +00:00
Owner
Copy Link

Strange. Check settings if it's disabled?

Strange. Check settings if it's disabled?
mmarif reviewed 2020-04-04 16:09:42 +00:00
Dismissed
app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java Outdated
@ -312,3 +345,3 @@
assert repoInfo != null;
textViewBadge.setText(repoInfo.getOpen_issues_count());
textViewBadgeIssue.setText(repoInfo.getOpen_issues_count());
mmarif commented 2020-04-04 16:08:19 +00:00
Owner

This line is the culprit from my testing. It need to be inside if statement like others.

This line is the culprit from my testing. It need to be inside if statement like others.
6543 commented 2020-04-04 16:10:46 +00:00
Author
Member

I'll fix it

I'll fix it
6543 commented 2020-04-04 16:18:53 +00:00
Author
Member
Copy Link

@mmarif fixed it (578283b10e)

@mmarif fixed it (578283b10eb991396eaf0db3f595bfac46003dbd)
mmarif reviewed 2020-04-04 16:23:13 +00:00
Dismissed
app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java Outdated
@ -315,0 +350,4 @@
if(tinyDb.getBoolean("enableCounterBadges")) {
assert repoInfo != null;
if(repoInfo.getOpen_pull_count() != null) {
mmarif commented 2020-04-04 16:22:59 +00:00
Owner

if(repoInfo.getOpen_pull_count() != null) { typo error here. Suppose to be getOpen_issues_count()

`if(repoInfo.getOpen_pull_count() != null) {` typo error here. Suppose to be `getOpen_issues_count()`
6543 added a new dependency 2020-04-04 17:16:52 +00:00
#353 Crowdin [2020-04-04] + add Spanish
mmarif approved these changes 2020-04-04 19:11:33 +00:00
Dismissed
mmarif added
LGTM-done
 and removed
LGTM-need
 labels 2020-04-04 19:11:48 +00:00
6543 removed a dependency 2020-04-04 19:18:58 +00:00
#353 Crowdin [2020-04-04] + add Spanish
mmarif closed this pull request 2020-04-04 19:20:30 +00:00
6543 deleted branch 218-PR-Tab_OpenNumber 2020-04-04 19:22:01 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.5.0
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#350
No description provided.
Delete Branch "6543/GitNex:218-PR-Tab_OpenNumber"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?