Improving design of "Repository Meta" #362

> Also wondering do you know any API or method to get commit counts? Not yet. If there is no way to even access the number of commits, please tell me. > Can you share screens of this, as I see you removed some info from that screen. Of course.

mmarif commented

2020-04-06 19:23:04 +00:00

Not yet. If there is no way to even access the number of commits, please tell me.

So far I haven't came across any object in the API which provides this. So maybe drop this for now?

> Not yet. If there is no way to even access the number of commits, please tell me. So far I haven't came across any object in the API which provides this. So maybe drop this for now?

opyale commented

2020-04-06 19:32:10 +00:00

No description provided.

Screenshot_20200406-212102.jpg

72 KiB

mmarif commented

2020-04-06 19:47:33 +00:00

This looks nice.

Are you planning to add some of the information back?

If some info are intrusive to this design like ssh url, clone url, date created etc. We can have a more info button below and when tap on it, opens a popup with the extra information.

This looks nice. Are you planning to add some of the information back? If some info are intrusive to this design like ssh url, clone url, date created etc. We can have a more info button below and when tap on it, opens a popup with the extra information.

opyale commented

2020-04-06 19:55:39 +00:00

Are you planning to add some of the information back?

Of course. There are a couple things which i want to do beyond my todo list.

If some info are intrusive to this design like ssh url, clone url, date created etc. We can have a more info button below and when tap on it, opens a popup with the extra information.

This sounds like a great idea. I will add it to my todo list.

> Are you planning to add some of the information back? Of course. There are a couple things which i want to do beyond my todo list. > If some info are intrusive to this design like ssh url, clone url, date created etc. We can have a more info button below and when tap on it, opens a popup with the extra information. This sounds like a great idea. I will add it to my todo list.

opyale commented

2020-04-06 21:04:36 +00:00

Current progress

Screenshot_20200406-230306.jpg

94 KiB

opyale commented

2020-04-06 21:53:44 +00:00

#366

opyale commented

2020-04-06 22:11:48 +00:00

Final state

Screenshot_20200407-001016.jpg

110 KiB

Screenshot_20200407-001019.jpg

142 KiB

opyale changed title from ~~[WIP] Improving design of "Repository Meta"~~ to Improving design of "Repository Meta"

2020-04-06 22:17:55 +00:00

opyale removed the

WIP

label 2020-04-06 22:18:08 +00:00

opyale commented

2020-04-06 22:20:04 +00:00

Light mode

Screenshot_20200407-001850.jpg

106 KiB

opyale added the

Ready

label 2020-04-06 22:30:26 +00:00

opyale commented

2020-04-06 22:31:39 +00:00

Final result

Screenshot_20200407-003057.jpg

106 KiB

mmarif commented

2020-04-07 04:40:29 +00:00

Good stuff.

Few design changes and suggestions.

Use link icon for website.
Hide website whole view if no data for website. noDataWebsite string may not be needed.
Move size to watchers, and watchers to size.
If PR object in API not found(old instances), hide that whole view. if(repoInfo.getOpen_pull_count() != null) {
Change button text to View Additional Information.
Popup header text Additional Information
Change cancel(popup) to close and load it from strings.
Last updated date/time(popup) should use the datetime function like created date.

Good stuff. Few design changes and suggestions. 1. Use link icon for website. 2. Hide website whole view if no data for website. `noDataWebsite` string may not be needed. 3. Move size to watchers, and watchers to size. 4. If PR object in API not found(old instances), hide that whole view. `if(repoInfo.getOpen_pull_count() != null) {` 5. Change button text to `View Additional Information`. 6. Popup header text `Additional Information` 7. Change cancel(popup) to close and load it from strings. 8. Last updated date/time(popup) should use the datetime function like created date.

mmarif commented

2020-04-07 04:43:39 +00:00

Missed this one. Website link color should be blue like last time.

opyale commented

2020-04-07 14:30:29 +00:00

Last updated date/time(popup) should use the datetime function like created date.

This is complicated. Especially because "last updated" is a string and not a date. I would suggest just leaving this as it is. Users which want to view "additional information" have to simply live with that.

Hide website whole view if no data for website. noDataWebsite string may not be needed.

I think this would be bad for UX. How should the user know if this is normal behaviour or a bug? I think "No website found" suits this case perfectly.

Every other suggestion should be fulfilled by now.

> Last updated date/time(popup) should use the datetime function like created date. This is complicated. Especially because "last updated" is a string and not a date. I would suggest just leaving this as it is. Users which want to view "additional information" have to simply live with that. > Hide website whole view if no data for website. noDataWebsite string may not be needed. I think this would be bad for UX. How should the user know if this is normal behaviour or a bug? I think "No website found" suits this case perfectly. Every other suggestion should be fulfilled by now.

Screenshot_20200407-161040.jpg

114 KiB

opyale changed title from ~~[WIP] Improving design of "Repository Meta"~~ to Improving design of "Repository Meta"

2020-04-07 17:17:13 +00:00

opyale changed title from ~~Improving design of "Repository Meta"~~ to [WIP] Improving design of "Repository Meta"

2020-04-07 17:20:55 +00:00

opyale changed title from ~~[WIP] Improving design of "Repository Meta"~~ to Improving design of "Repository Meta"

2020-04-07 17:43:23 +00:00

mmarif commented

2020-04-07 21:16:17 +00:00

This is complicated. Especially because “last updated” is a string and not a date. I would suggest just leaving this as it is. Users which want to view “additional information” have to simply live with that.

It's ok, I will send a fix after this merged.

I think this would be bad for UX. How should the user know if this is normal behaviour or a bug? I think “No website found” suits this case perfectly.

Ok

> This is complicated. Especially because “last updated” is a string and not a date. I would suggest just leaving this as it is. Users which want to view “additional information” have to simply live with that. It's ok, I will send a fix after this merged. > I think this would be bad for UX. How should the user know if this is normal behaviour or a bug? I think “No website found” suits this case perfectly. Ok

mmarif removed the

Ready

label 2020-04-07 21:16:34 +00:00

mmarif added this to the 2.5.0 milestone 2020-04-07 21:16:42 +00:00

mmarif approved these changes 2020-04-07 21:16:54 +00:00

Dismissed

opyale commented

2020-04-07 21:16:55 +00:00