Fix version API auth check #391

						
				@ -447,6 +449,7 @@ public class LoginActivity extends BaseActivity implements View.OnClickListener

				                }

				                else if (responseVersion.code() == 403) {

6543 commented

2020-04-12 19:07:30 +00:00

instead of using a flag we could use loginToken_ or basic auth if we get a 403

instead of using a flag we could use `loginToken_` or **basic auth** if we get a 403

mmarif commented

2020-04-12 19:17:38 +00:00

instead of using a flag we could use loginToken_ or basic auth if we get a 403

Don't quite understand this part. Do you mean call the API inside 403?

> instead of using a flag we could use loginToken_ or basic auth if we get a 403 Don't quite understand this part. Do you mean call the API inside 403?

6543 approved these changes 2020-04-12 19:07:55 +00:00

Dismissed

6543 left a comment

should I try to fix this?

6543 requested changes 2020-04-12 19:08:08 +00:00

Dismissed

6543 left a comment

wrong button

mmarif commented

2020-04-12 19:18:01 +00:00

should I try to fix this?

Fix??

> should I try to fix this? Fix??

6543 commented

2020-04-12 19:58:10 +00:00

sory *Impruve it

mmarif commented

2020-04-12 20:04:04 +00:00

If you mean adding new API call in 403, I would suggest not to do that as we already have so many calls in the Login screen. Avoiding more is good for fast logins.

Also we have get version in main activity, so that can be used.

But if you have other improvements beside this please push and I will check.

If you mean adding new API call in 403, I would suggest not to do that as we already have so many calls in the Login screen. Avoiding more is good for fast logins. Also we have get version in main activity, so that can be used. But if you have other improvements beside this please push and I will check.

6543 self-assigned this 2020-04-12 20:20:05 +00:00

6543 started working 2020-04-12 21:43:49 +00:00

6543 stopped working 2020-04-12 22:14:38 +00:00

30min 49s

6543 referenced this pull request

2020-04-12 22:14:46 +00:00

Fix version API auth check #399

6543 commented

2020-04-12 22:15:48 +00:00

I go the other way around ... so I created a new pull to dont destroy this one

@mmarif have a look at #399 and what you think of

I go the other way around ... so I created a new pull to dont destroy this one @mmarif have a look at #399 and what you think of