Remember login type #392

mmarif · 2020-04-12T18:27:48Z

mmarif commented

2020-04-12 18:27:48 +00:00

Closes #372

mmarif added this to the 2.5.0 milestone 2020-04-12 18:27:48 +00:00

mmarif added the

Improvement

label 2020-04-12 18:27:48 +00:00

mmarif self-assigned this 2020-04-12 18:27:48 +00:00

6543 approved these changes 2020-04-12 19:02:49 +00:00

Dismissed

6543 left a comment

loginType could be string and types are "token" or "basic" for better code documentation
but it works

loginType could be string and types are "token" or "basic" for better code documentation but it works

6543 commented

2020-04-12 19:03:15 +00:00

loginType could be string and types are "token" or "basic" for better code documentation but it works

👍 1

mmarif referenced this issue from a commit

2020-04-12 19:04:04 +00:00

Remember login type (#392) Merge branch 'master' into 372-remember-login-type Remember login type Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/392 Reviewed-by: 6543 <6543@noreply.gitea.io>

mmarif closed this pull request

2020-04-12 19:04:05 +00:00

mmarif commented

2020-04-12 19:05:20 +00:00

loginType could be string and types are “token” or “basic” for better code documentation but it works

Initially did it that way, but then thought easy this way. Can be easily extended if needed later. But at this moment it is fine and will work.

> loginType could be string and types are “token” or “basic” for better code documentation but it works Initially did it that way, but then thought easy this way. Can be easily extended if needed later. But at this moment it is fine and will work.

mmarif deleted branch 372-remember-login-type

2020-04-12 19:05:54 +00:00

mmarif commented

2020-04-12 19:07:32 +00:00

Or maybe let me do it that way so we can use it in the future easily, no backward issues.

👍 1

This repo is archived. You cannot comment on pull requests.

No reviewers