gitnex/GitNex

Archived

Themes for source code in file viewer #403

Merged

mmarif merged 6 commits from 396-themes-file-veiwer into master

2020-04-13 15:23:34 +00:00

mmarif commented

2020-04-13 07:28:35 +00:00

Owner

Closes #396

Closes #396

mmarif added this to the 2.5.0 milestone 2020-04-13 07:28:35 +00:00

mmarif added the

label 2020-04-13 07:28:35 +00:00

mmarif self-assigned this 2020-04-13 07:28:35 +00:00

mmarif added the

label 2020-04-13 07:28:46 +00:00

6543 reviewed 2020-04-13 12:00:25 +00:00

Dismissed

6543 left a comment

Member

one nit - I'll change it for you

one nit - I'll change it for you

app/src/main/java/org/mian/gitnex/activities/FileViewActivity.java Outdated

						
				@ -176,3 +176,3 @@

				                            singleCodeContents.setVisibility(View.VISIBLE);

				                            singleCodeContents.setTheme(Theme.GRUVBOX_DARK);

				                            if(tinyDb.getInt("fileviewerSourceCodeThemeId") == 1) {

6543 commented

2020-04-13 11:59:22 +00:00

Member

can you cange this to a switch ... case block?

can you cange this to a switch ... case block?

6543 commented

2020-04-13 12:07:51 +00:00

Member

@mmarif I only canged this: efe755255d

the rest of the diff is only code-format

@mmarif I only canged this: https://gitea.com/gitnex/GitNex/commit/efe755255d9f84a7ba6a50fd197afdae73ee1af2 the rest of the diff is only code-format

mmarif commented

2020-04-13 14:01:17 +00:00

Author

Owner

I only canged this: efe755255d
the rest of the diff is only code-format

Ok.

> I only canged this: efe755255d the rest of the diff is only code-format Ok.

6543 approved these changes 2020-04-13 15:08:45 +00:00

Dismissed

6543 added

and removed

labels 2020-04-13 15:08:54 +00:00

mmarif referenced this issue from a commit

2020-04-13 15:23:33 +00:00

Themes for source code in file viewer (#403) reformat code move from else-if to switch-case Merge branch 'master' into 396-themes-file-veiwer Merge branch 'master' into 396-themes-file-veiwer Make string translatable false Themes for source code in file viewer Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/403 Reviewed-by: 6543 <6543@noreply.gitea.io>

mmarif closed this pull request

2020-04-13 15:23:34 +00:00

mmarif deleted branch 396-themes-file-veiwer

2020-04-13 15:23:50 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

Accepting-merge-requests

External-dependecy

Priority-critical

Priority-medium

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#403

No description provided.