[FrontPort #429] Dismiss bottom sheet on subscribe/unsubscribe to issue & Fix #428

mmarif · 2020-04-18T12:38:27Z

mmarif commented

2020-04-18 12:38:27 +00:00

Does not really fix the issue as there is no way to handle this without a proper call.
And dismiss does not really work in this.

But added some improvements to it for future usage.

Also fixed issue close/reopen along the way.

Does not really fix the issue as there is no way to handle this without a proper call. And dismiss does not really work in this. But added some improvements to it for future usage. Also fixed issue close/reopen along the way.

mmarif added this to the 2.5.0 milestone 2020-04-18 12:38:27 +00:00

mmarif added the

Bug

label 2020-04-18 12:38:27 +00:00

mmarif self-assigned this 2020-04-18 12:38:28 +00:00

mmarif added the

Backport

label 2020-04-18 12:40:21 +00:00

mmarif changed title from ~~Does not really fix the issue~~ to #427 Does not really fix the issue

2020-04-18 12:40:47 +00:00

mmarif modified the milestone from 2.5.0 to 3.0.0

2020-04-18 12:46:08 +00:00

mmarif removed the

Backport

label 2020-04-18 12:46:18 +00:00

mmarif changed title from ~~#427 Does not really fix the issue~~ to [Backport #428] Does not really fix the issue

2020-04-18 12:47:59 +00:00

mmarif changed title from ~~[Backport #428] Does not really fix the issue~~ to [Backport #429] Does not really fix the issue

2020-04-18 12:48:59 +00:00

6543 added the

Blocked

label 2020-04-18 12:59:55 +00:00

mmarif commented

2020-04-18 14:15:56 +00:00

@6543 are we going to wait for the API for this?

In that case I can send another PR to fix the close/reopen issue.

@6543 are we going to wait for the API for this? In that case I can send another PR to fix the close/reopen issue.

6543 changed title from ~~[Backport #429] Does not really fix the issue~~ to [FrontPort #429] Dismiss bottom sheet on subscribe/unsubscribe to issue & Fix

2020-04-18 14:23:04 +00:00

6543 approved these changes 2020-04-18 14:23:11 +00:00

Dismissed

6543 added

LGTM-done

and removed

Blocked

labels 2020-04-18 14:23:41 +00:00

mmarif referenced this issue from a commit

2020-04-18 14:29:44 +00:00

[FrontPort #429] Dismiss bottom sheet on subscribe/unsubscribe to issue & Fix (#428) Merge branch 'master' into 427-dismiss-bottom-sheet Does not really fix the issue as there is way to handle this without a proper call. And dismiss does not work properly either. But added few improvements and fixed close/reopen issue along the way. Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/428 Reviewed-by: 6543 <6543@noreply.gitea.io>

mmarif merged commit af6cbfdb66 into master