gitnex/GitNex

Archived

Moving HighlightJS into app. #477

Merged

mmarif merged 4 commits from :webview-highlighting into master

2020-04-30 06:28:36 +00:00

opyale commented

2020-04-28 20:36:03 +00:00

Member

Rewriting code, updating JS libraries and only keeping necessary stuff. Crash is fixed now.

Closes #407 #474

Rewriting code, updating JS libraries and only keeping necessary stuff. Crash is fixed now. Closes #407 #474

Screenshot_1588107161.png

124 KiB

opyale added this to the 3.0.0 milestone 2020-04-28 20:36:03 +00:00

opyale added the

labels 2020-04-28 20:36:25 +00:00

opyale requested review from mmarif 2020-04-28 20:36:45 +00:00

opyale changed title from ~~Moving HighlightJS to app.~~ to Moving HighlightJS into app.

2020-04-28 21:51:32 +00:00

mmarif added

and removed

labels 2020-04-29 06:42:29 +00:00

mmarif referenced this pull request

2020-04-29 07:01:39 +00:00

Quick fix for crashes on Android 5 and 6 in file viewer using highlightjs #475

mmarif commented

2020-04-29 07:43:00 +00:00

Owner

Looks good and working as expected.

Just one thing, line numbers and actual code are way too close to each other. Should have at least little space between to separate them like how the current one is.

Nothing more from my side.

Looks good and working as expected. Just one thing, line numbers and actual code are way too close to each other. Should have at least little space between to separate them like how the current one is. Nothing more from my side.

Screenshot_20200429_124111.png

18 KiB

opyale commented

2020-04-30 01:42:04 +00:00

Author

Member

@mmarif Does it work for you now with 40187b29f5 ?

@mmarif Does it work for you now with 40187b29f5fc9f5e8cff2b87ea4803795db1a9bd ?

mmarif commented

2020-04-30 06:25:03 +00:00

Owner

All good and working now.

All good and working now.

mmarif approved these changes 2020-04-30 06:26:31 +00:00

Dismissed

mmarif added

and removed

labels 2020-04-30 06:26:43 +00:00

mmarif referenced this issue from a commit

2020-04-30 06:28:30 +00:00

Moving HighlightJS into app. (#477) Final fixes and improvements. Fixing crash of app in Android 5.0 Removing unused theme. Moving HighlightJS to app. Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/477 Reviewed-by: M M Arif <mmarif@swatian.com>

mmarif merged commit 5d1efe0f3f into master

2020-04-30 06:28:31 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

Accepting-merge-requests

External-dependecy

Priority-critical

Priority-medium

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#477

No description provided.