Add Explore function #71

Merged
mmarif merged 4 commits from 6543/GitNex:repoSearch into master 2019-10-10 16:02:07 +00:00
Member

should resolve mmarif/GitNex#66

this is a draft and i just test how hard this is to implement ...

should resolve https://gitea.com/mmarif/GitNex/issues/66 this is a draft and i just test how hard this is to implement ...
Author
Member

@mmarif you dont have to wirte me entire diffs anymore as for mmarif/GitNex#32 you can directly wrie to my forg i give you wrie permission ... | we will see what we do with this ;)

@mmarif you dont have to wirte me entire diffs anymore as for https://gitea.com/mmarif/GitNex/pulls/32 you can directly wrie to my [forg](https://gitea.com/6543/GitNex/src/branch/repoSearch) i give you wrie permission ... | we will see what we do with this ;)
First-time contributor

pic doesn't show up

pic doesn't show up
Author
Member

@succfemboi upload of gitea.com now works again ... it seams the are working on something related to this

@succfemboi upload of gitea.com now works again ... it seams the are working on something related to this
First-time contributor

It still doesn't show up on latest gitnex

It still doesn't show up on latest gitnex
Author
Member
* GitNex does NOT support attachments jet (https://gitea.com/mmarif/GitNex/issues/56) * and it doesnt show pictures in markdown (https://gitea.com/mmarif/GitNex/issues/72)
Owner

@succfemboi there is no attachment API yet. When it's available will be implemented.

@6543 current markdown lib does support images, but with strict markdown format. If format is different it will not render them.

@succfemboi there is no attachment API yet. When it's available will be implemented. @6543 current markdown lib does support images, but with strict markdown format. If format is different it will not render them.
mmarif added the
Major-release
Feature
labels 2019-09-28 18:22:22 +00:00
mmarif removed the
Major-release
label 2019-09-28 18:39:51 +00:00
Author
Member

so work on this ...

so work on this ...
Author
Member

repos/search?q={query}&topic=false&includeDesc=true&private=false

  • {query} = search string
  • topic=false = must match topic
  • includeDesc=true = look also in repo descripton
  • private=false = is public
repos/search?q={query}&topic=false&includeDesc=true&private=false * {query} = search string * topic=false = must match topic * includeDesc=true = look also in repo descripton * private=false = is public
Author
Member

is this the right way to define an API point? @mmarif

89c65abdcf

is this the right way to define an API point? @mmarif https://gitea.com/6543/GitNex/commit/89c65abdcf0df05c74a916993910df21b156628c
Owner

You can pass the parameters directly to the API, like

@GET("repos/search") // get all repos who match query string
    Call<List<UserRepositories>> queryRepos(@Header("Authorization") String token, @Query("q") String searchKeyword);
You can pass the parameters directly to the API, like ``` @GET("repos/search") // get all repos who match query string Call<List<UserRepositories>> queryRepos(@Header("Authorization") String token, @Query("q") String searchKeyword); ```
Owner
This can help https://gitea.com/mmarif/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/interfaces/ApiInterface.java#L153
Author
Member

only available in 1.10.x:

  • includeDesc
  • topic

so will add later if it goes to v2.2.0

only available in 1.10.x: * includeDesc * topic so will add later if it goes to v2.2.0
Author
Member

@mmarif I have a question: where can i find the java component of drawer_menu.xml ?

@mmarif I have a question: where can i find the java component of drawer_menu.xml ?
mmarif added this to the 2.1.0 milestone 2019-10-01 05:46:25 +00:00
Owner

I will work with you on this. Added it to nav java.

I will work with you on this. Added it to nav java.
Author
Member

Wow thanks!

Wow thanks!
mmarif modified the milestone from 2.1.0 to 2.2.0 2019-10-01 15:19:09 +00:00
Author
Member

will work on it this avternoon if i had time - researched and tested translation tools & webhooks co.

will work on it this ~~avternoon~~ if i had time - researched and tested translation tools & webhooks co.
6543 was assigned by mmarif 2019-10-04 18:41:52 +00:00
mmarif self-assigned this 2019-10-04 18:41:53 +00:00
Author
Member

@mmarif rebased + commits combined to cleanup logs and so on

@mmarif rebased + commits combined to cleanup logs and so on
Owner

@6543 this is ready for testing. :)

@6543 this is ready for testing. :)
mmarif added the
Ready
label 2019-10-10 13:47:10 +00:00
mmarif changed title from [WIP] add Explore function to [WIP] Add Explore function 2019-10-10 13:47:29 +00:00
Author
Member

Nice you ar quite fast ...
wait I'll test it

Nice you ar quite fast ... wait I'll test it
Author
Member

-> Works NICE

Merge and new PR to open the Repos or work in this PR to open the Repos?

-> Works NICE Merge and new PR to open the Repos or work in this PR to open the Repos?
6543 reviewed 2019-10-10 14:55:07 +00:00
Dismissed
6543 left a comment
Author
Member

?!? I cant aprove it

?!? I cant aprove it
Owner

Merge and new PR to open the Repos or work in this PR to open the Repos?

I am going to enable that in this PR. Will be quick.

> Merge and new PR to open the Repos or work in this PR to open the Repos? I am going to enable that in this PR. Will be quick.
mmarif changed title from [WIP] Add Explore function to Add Explore function 2019-10-10 15:53:46 +00:00
mmarif added
LGTM-need
and removed
Ready
labels 2019-10-10 15:54:09 +00:00
Owner

This PR is done from my side. @6543 you can check and approve.

This PR is done from my side. @6543 you can check and approve.
6543 reviewed 2019-10-10 15:59:23 +00:00
Dismissed
6543 left a comment
Author
Member

no I dont have the right to aprove this

no I dont have the right to aprove this
Author
Member

-> would say is ready for merge 🚀

-> would say is ready for merge :rocket:
Owner

Haha, it is your PR suppose I approve. I guess I need some sleep. :)

Haha, it is your PR suppose I approve. I guess I need some sleep. :)
mmarif approved these changes 2019-10-10 16:01:05 +00:00
Dismissed
mmarif added
LGTM-done
and removed
LGTM-need
labels 2019-10-10 16:01:21 +00:00
mmarif closed this pull request 2019-10-10 16:02:07 +00:00
Author
Member

o right ... overlook the smal things ... is quite common

o right ... overlook the smal things ... is quite common
mmarif closed this pull request 2019-10-10 16:02:07 +00:00
6543 deleted branch repoSearch 2019-10-10 16:02:16 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#71
No description provided.