Fix session destroy not clearing cookie #6

Merged
wolfogre merged 1 commits from zig1000/session:fix-session-destroy into master 2023-06-13 03:59:29 +00:00
Contributor

Chrome may not delete a cookie if the Domain field is missing from the Set-Cookie request. Add the Domain field - as well as Secure and SameSite for completeness - to session.go's Manager.Destroy cookie response update.

Chrome may not delete a cookie if the Domain field is missing from the Set-Cookie request. Add the `Domain` field - as well as `Secure` and `SameSite` for completeness - to `session.go`'s Manager.Destroy cookie response update.
zig1000 added 1 commit 2023-06-07 19:19:08 +00:00
Some checks failed
test / check and test (pull_request) Has been cancelled
d453cc0a77
Fix session destroy not clearing cookie
lunny approved these changes 2023-06-13 03:47:12 +00:00
wolfogre approved these changes 2023-06-13 03:55:01 +00:00
wolfogre merged commit 39541325fa into master 2023-06-13 03:59:29 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: go-chi/session#6
No description provided.