Fix session destroy not clearing cookie #6

zig1000 · 2023-06-07T19:19:06Z

zig1000 commented

2023-06-07 19:19:06 +00:00

Chrome may not delete a cookie if the Domain field is missing from the Set-Cookie request. Add the Domain field - as well as Secure and SameSite for completeness - to session.go's Manager.Destroy cookie response update.

Chrome may not delete a cookie if the Domain field is missing from the Set-Cookie request. Add the `Domain` field - as well as `Secure` and `SameSite` for completeness - to `session.go`'s Manager.Destroy cookie response update.

zig1000 added 1 commit 2023-06-07 19:19:08 +00:00

Fix session destroy not clearing cookie

test / check and test (pull_request) Has been cancelled

Details

d453cc0a77

lunny approved these changes 2023-06-13 03:47:12 +00:00

wolfogre approved these changes 2023-06-13 03:55:01 +00:00

wolfogre merged commit 39541325fa into master

2023-06-13 03:59:29 +00:00

wolfogre referenced this issue from a commit

2023-06-13 03:59:31 +00:00

Fix session destroy not clearing cookie (#6)