goftp/ftpd
goftp/ftpd
5
8
Fork 3
Code Issues 1 Pull Requests Actions Releases 1 Wiki Activity

[WIP] Add rclone integration tests #8

Closed
sapk wants to merge 2 commits from sapk-fork/add-integration-tests into main
pull from: sapk-fork/add-integration-tests
merge into: goftp:main
Conversation 3 Commits 2 Files Changed 1 +127
sapk commented 2018-07-15 12:45:37 +00:00 (Migrated from github.com)
Copy Link

In order to corner down what happen in PR for integration goftp in rclone (https://github.com/ncw/rclone/pull/2232), I added an integration test to use rclone as a client of ftpd.
It seems to have the same hanging bug. I will try to use this PR to corner down the issue and maybe it will be usefull to keep an itegration test to validate https://github.com/goftp/ftpd and https://github.com/goftp/server.

In order to corner down what happen in PR for integration goftp in rclone (https://github.com/ncw/rclone/pull/2232), I added an integration test to use rclone as a client of ftpd. It seems to have the same hanging bug. I will try to use this PR to corner down the issue and maybe it will be usefull to keep an itegration test to validate https://github.com/goftp/ftpd and https://github.com/goftp/server.
lunny commented 2018-07-16 13:29:15 +00:00
Copy Link

@sapk CI is not enabled on this project.

@sapk CI is not enabled on this project.
sapk commented 2018-07-16 19:34:38 +00:00 (Migrated from github.com)
Copy Link

@lunny I think of it after. I wanted to test if I have the same issue as using a rclone backend. I will close this one.
Do you want that I do it in goftp/server ? (and it seems more logical since it is where the code is)

@lunny I think of it after. I wanted to test if I have the same issue as using a rclone backend. I will close this one. Do you want that I do it in goftp/server ? (and it seems more logical since it is where the code is)
lunny commented 2018-07-21 10:56:47 +00:00
Copy Link

@sapk please.

@sapk please.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
break

   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
break
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: goftp/ftpd#8
No description provided.
Delete Branch "sapk-fork/add-integration-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?