Use custom search for each filter type in dashboard #2343

lunny · 2017-08-20T13:14:10Z

Morlinest commented

2017-08-20 13:14:10 +00:00

(Migrated from github.com)

Based on #2326 (need to be merged first)
Discussion on #2312

Fast network (no restrictions):

Slow network ("Slow 3G" through Chrome network setting):

Edit: Updated screnshots/gifs.

Based on #2326 (need to be merged first) Discussion on #2312 Fast network (no restrictions): ![2017-11-01_16-26-45](https://user-images.githubusercontent.com/12720041/32282754-be280b34-bf22-11e7-9106-028890beaa1f.gif) Slow network ("Slow 3G" through Chrome network setting): ![2017-11-01_16-24-56](https://user-images.githubusercontent.com/12720041/32282763-c4b0ba82-bf22-11e7-99ba-5994ae81cd8c.gif) Edit: Updated screnshots/gifs.

❤️ 1

jonasfranz (Migrated from github.com) requested changes 2017-08-21 19:00:15 +00:00

models/repo_list.go

jonasfranz (Migrated from github.com) commented

2017-08-21 18:53:44 +00:00

Could you please run make generate-swagger to regenerate the swagger spec? This might resolve the conflict. If not please resolve the conflicts manually.

Could you please run `make generate-swagger` to regenerate the swagger spec? This might resolve the conflict. If not please resolve the conflicts manually.

jonasfranz (Migrated from github.com) commented

2017-08-21 18:58:49 +00:00

Please add swagger:parameter like here: aa6a2c9962/models/repo_list.go (L92)

Please add `swagger:parameter` like here: https://github.com/Morlinest/gitea/blob/aa6a2c996252707a1ada79c52661e1f464bccee9/models/repo_list.go#L92

public/swagger.v1.json

jonasfranz (Migrated from github.com) commented

2017-08-21 18:59:41 +00:00

Do not add swagger stuff manually because it will be overwritten if you run make generate-swagger.

Do not add swagger stuff manually because it will be overwritten if you run `make generate-swagger`.

Morlinest (Migrated from github.com) reviewed 2017-08-21 19:53:34 +00:00

public/swagger.v1.json

Morlinest (Migrated from github.com) commented

2017-08-21 19:53:34 +00:00

Never touched this file manually. It was generated by make generate-swagger (exactly mingw32-make generate-swagger).

Never touched this file manually. It was generated by `make generate-swagger` (exactly `mingw32-make generate-swagger`).

Morlinest (Migrated from github.com) reviewed 2017-08-21 19:55:03 +00:00

models/repo_list.go

Morlinest (Migrated from github.com) commented

2017-08-21 19:55:03 +00:00

I did. Conflicts are new due to new master. I'll rebase and run it again.

Morlinest (Migrated from github.com) reviewed 2017-08-21 19:55:09 +00:00

models/repo_list.go

Morlinest (Migrated from github.com) commented

2017-08-21 19:55:09 +00:00

OK

Morlinest commented

2017-08-21 21:25:12 +00:00

(Migrated from github.com)

@JonasFranzDEV Please comment first 2 commits in #2326. This PR is based on it (master -> #2326 -> #2343).

codecov-io commented

2017-09-16 15:01:17 +00:00

(Migrated from github.com)

Codecov Report

Merging #2343 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2343   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266ebf8...27a4890. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2343?src=pr&el=h1) Report > Merging [#2343](https://codecov.io/gh/go-gitea/gitea/pull/2343?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/266ebf82001bd1daadadfad61c7c576e6adaccab?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/2343/graphs/tree.svg?token=t1G57YGbPy&src=pr&height=150&width=650)](https://codecov.io/gh/go-gitea/gitea/pull/2343?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2343 +/- ## ======================================= Coverage 26.84% 26.84% ======================================= Files 89 89 Lines 17608 17608 ======================================= Hits 4727 4727 Misses 12195 12195 Partials 686 686 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2343?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2343?src=pr&el=footer). Last update [266ebf8...27a4890](https://codecov.io/gh/go-gitea/gitea/pull/2343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Morlinest commented

2017-09-16 16:15:12 +00:00

(Migrated from github.com)

Rebased on top of #2371 + #2326. Only last commit is new.

Morlinest commented

2017-10-26 21:53:26 +00:00

(Migrated from github.com)

PR reopened as all needed features were merged. Rebased on master, ready for testing, review and comments.

lafriks commented

2017-10-26 22:05:16 +00:00

(Migrated from github.com)

@JonasFranzDEV please review again

Morlinest commented

2017-11-01 15:32:54 +00:00

(Migrated from github.com)

@lafriks FYI he was actually reviewing another PR code (as this PR was not based on master). That code is not part of this PR anymore.

Morlinest commented

2017-11-01 15:38:04 +00:00

(Migrated from github.com)

Changed UI by removing second loader that was causing "flickering" effect if search was fast. Now the repository counter is reset on each filter change. Adding new screenshots (limit set to 5 repositories for this tests).

Edit: Screenshots moved to PR description.

Changed UI by removing second loader that was causing "flickering" effect if search was fast. Now the repository counter is reset on each filter change. Adding new screenshots (limit set to 5 repositories for this tests). Edit: Screenshots moved to PR description.

lunny commented

2017-11-01 15:44:02 +00:00

LGTM

lafriks commented

2017-11-01 15:47:26 +00:00

(Migrated from github.com)

LGTM

lafriks commented

2017-11-01 19:21:21 +00:00

(Migrated from github.com)

Make LG-TM work

lafriks commented