lunny/gitea
Archived
1
1
Fork 1
Code Issues 1.7k Pull Requests 154 Projects Releases 128 Wiki Activity

Prevent NPE on commenting on lines with invalidated comments (with migration) #12549

Merged
lunny merged 4 commits from fix-12239-review-page-500-with-migration into master 2020-08-21 07:53:15 +00:00
Conversation 0 Commits 4 Files Changed 3 +135 -1

4 Commits

Author SHA1 Message Date
zeripath
b5e9c48f48
Merge branch 'master' into fix-12239-review-page-500-with-migration 2020-08-20 22:34:22 +01:00
Andrew Thornton
16fd2c3cf2
Add migration and remove template hacks 
Signed-off-by: Andrew Thornton <art27@cantab.net>
 2020-08-20 22:22:24 +01:00
Andrew Thornton
80ab986b21
Add hack around to show the broken comments 
Signed-off-by: Andrew Thornton <art27@cantab.net>
 2020-08-20 20:34:42 +01:00
Andrew Thornton
309fd94161
Prevent NPE on commenting on lines with invalidated comments 
Only check for a review if we are replying to a previous review.

Prevent the NPE in #12239 by assuming that a comment without a Review is
non-pending.

Fix #12239

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2020-08-20 18:32:47 +01:00