Change docker tag logic #16421

techknowlogick · 2021-07-13T22:27:46Z

techknowlogick commented

2021-07-13 22:27:46 +00:00

This PR changes the image tagged as :latest on docker hub to represent the :latest released version of Gitea.

:latest will now be mapped to latest tag on the 1.15 branch.
:dev will represent the latest build from the main branch.

Replace: #15889
Fixes #15622

thanks to @pat-s for the initial work on this PR :)

⚠️ BREAKING ⚠️

Previously the :latest docker tag would map to the latest build from main. Users who wish to use the absolute latest version of Gitea should migrate to use :dev and we would ask that at least some users do consider using the :dev tag if possible.

This PR changes the image tagged as `:latest` on docker hub to represent the `:latest` released version of Gitea. * `:latest` will now be mapped to latest tag on the 1.15 branch. * `:dev` will represent the latest build from the `main` branch. Replace: #15889 Fixes #15622 thanks to @pat-s for the initial work on this PR :) ## :warning: BREAKING :warning: Previously the `:latest` docker tag would map to the latest build from `main`. Users who wish to use the absolute latest version of Gitea should migrate to use `:dev` and we would ask that at least some users do consider using the `:dev` tag if possible.

lafriks (Migrated from github.com) approved these changes 2021-07-14 15:22:38 +00:00

kdumontnu requested changes 2021-07-14 15:31:49 +00:00

kdumontnu left a comment

This requires an update in gitea/docs/content/doc/installation/with-docker* docs, right?

This requires an update in `gitea/docs/content/doc/installation/with-docker*` docs, right?

.drone.yml Outdated

						
				@ -897,0 +1042,4 @@

				      ignore_missing: true

				      spec: docker/manifest.rootless.tmpl

				      password:

				        from_secret: docker_password

kdumontnu commented

2021-07-14 15:28:13 +00:00

Does this need the fetch-tags step since we are not using version tags in the docker build step?

Not sure if the dockerfiles need tags for RUN if [ -n "${GITEA_VERSION}" ]; then git checkout "${GITEA_VERSION}";, but if I understand the logic, if [ -n "${GITEA_VERSION}" ] should always resolve false here for dev build.

Does this need the `fetch-tags` step since we are not using version tags in the docker build step? Not sure if the dockerfiles need tags for `RUN if [ -n "${GITEA_VERSION}" ]; then git checkout "${GITEA_VERSION}";`, but if I understand the logic, `if [ -n "${GITEA_VERSION}" ]` should always resolve false here for dev build.

docker/manifest.rootless.tmpl Outdated

kdumontnu commented

2021-07-14 15:16:52 +00:00

    image: gitea/gitea:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}dev{{/if}}-linux-amd64-rootless

For consistency with the image logic above

```suggestion image: gitea/gitea:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}dev{{/if}}-linux-amd64-rootless ``` For consistency with the image logic above

kdumontnu commented

2021-07-14 15:17:07 +00:00

    image: gitea/gitea:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}dev{{/if}}-linux-arm64-rootless

```suggestion image: gitea/gitea:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}dev{{/if}}-linux-arm64-rootless ```

techknowlogick reviewed 2021-07-14 15:48:23 +00:00

.drone.yml Outdated

						
				@ -897,0 +1042,4 @@

				      ignore_missing: true

				      spec: docker/manifest.rootless.tmpl

				      password:

				        from_secret: docker_password

techknowlogick commented

2021-07-14 15:48:23 +00:00

It does need the fetch-tags logic, as otherwise we can't generate a version based on git information (eg. 1.15.0+dev-582-g3dcb3e907).

It does need the fetch-tags logic, as otherwise we can't generate a version based on git information (eg. `1.15.0+dev-582-g3dcb3e907`).

kdumontnu reviewed 2021-07-14 16:03:21 +00:00

docs/content/doc/installation/with-docker-rootless.en-us.md Outdated

						
				@ -44,3 +42,4 @@

				    image: gitea/gitea:{{< version >}}-rootless

				    restart: always

				    volumes:

				      - ./data:/var/lib/gitea

kdumontnu commented

2021-07-14 16:03:21 +00:00

latest-rootless should still work, right? Or are you just suggesting people version-lock their docker-compose files?

`latest-rootless` should still work, right? Or are you just suggesting people version-lock their docker-compose files?

techknowlogick reviewed 2021-07-14 16:12:52 +00:00

docs/content/doc/installation/with-docker-rootless.en-us.md Outdated

						
				@ -44,3 +42,4 @@

				    image: gitea/gitea:{{< version >}}-rootless

				    restart: always

				    volumes:

				      - ./data:/var/lib/gitea