Change docker tag logic #16421
Labels
No Label
backport/done
backport/v1.0
backport/v1.1
backport/v1.10
backport/v1.11
backport/v1.12
backport/v1.13
backport/v1.14
backport/v1.15
backport/v1.2
backport/v1.3
backport/v1.4
backport/v1.5
backport/v1.6
backport/v1.7
backport/v1.8
backport/v1.9
bounty
changelog
dependencies
frontport/done
frontport/main
good first issue
Hacktoberfest
hacktoberfest-accepted
in progress
kind/api
kind/breaking
kind/bug
kind/build
kind/deployment
kind/deprecated
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/misc
kind/moderation
kind/package
kind/proposal
kind/question
kind/refactor
kind/regression
kind/security
kind/summary
kind/testing
kind/translation
kind/ui
kind/upstream-related
kind/usability
kind/ux
lgtm/done
lgtm/need 1
lgtm/need 2
performance/bigrepo
performance/cpu
performance/memory
performance/speed
priority/critical
priority/low
priority/maybe
priority/medium
proposal/rejected
reviewed/confirmed
reviewed/duplicate
reviewed/fixed
reviewed/invalid
reviewed/not-a-bug
reviewed/wontfix
skip-changelog
stale
status/blocked
status/needs-feedback
status/wip
theme/2fa
theme/authentication
theme/avatar
theme/backup-restore
theme/docker
theme/federation
theme/issues
theme/kanban
theme/markdown
theme/migration
theme/mobile
theme/pr
theme/signing
theme/sqlite
theme/timetracker
theme/webhook
theme/wiki
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: lunny/gitea#16421
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "docker-changes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR changes the image tagged as
:latest
on docker hub to represent the:latest
released version of Gitea.:latest
will now be mapped to latest tag on the 1.15 branch.:dev
will represent the latest build from themain
branch.Replace: #15889
Fixes #15622
thanks to @pat-s for the initial work on this PR :)
⚠️ BREAKING ⚠️
Previously the
:latest
docker tag would map to the latest build frommain
. Users who wish to use the absolute latest version of Gitea should migrate to use:dev
and we would ask that at least some users do consider using the:dev
tag if possible.This requires an update in
gitea/docs/content/doc/installation/with-docker*
docs, right?@ -897,0 +1042,4 @@
ignore_missing: true
spec: docker/manifest.rootless.tmpl
password:
from_secret: docker_password
Does this need the
fetch-tags
step since we are not using version tags in the docker build step?Not sure if the dockerfiles need tags for
RUN if [ -n "${GITEA_VERSION}" ]; then git checkout "${GITEA_VERSION}";
, but if I understand the logic,if [ -n "${GITEA_VERSION}" ]
should always resolve false here for dev build.For consistency with the image logic above
@ -897,0 +1042,4 @@
ignore_missing: true
spec: docker/manifest.rootless.tmpl
password:
from_secret: docker_password
It does need the fetch-tags logic, as otherwise we can't generate a version based on git information (eg.
1.15.0+dev-582-g3dcb3e907
).@ -44,3 +42,4 @@
image: gitea/gitea:{{< version >}}-rootless
restart: always
volumes:
- ./data:/var/lib/gitea
latest-rootless
should still work, right? Or are you just suggesting people version-lock their docker-compose files?@ -44,3 +42,4 @@
image: gitea/gitea:{{< version >}}-rootless
restart: always
volumes:
- ./data:/var/lib/gitea
Yup, it still works, but your assumption of what I was doing was correct. This also aligns with what the other page has.
? (fair warning: I'm not a docker expert, but it resolves the initial issues I saw)