Gitea Snap update issue #16209 #17157

wxiaoguang · 2021-09-26T11:53:57Z

OleHusgaard commented

2021-09-26 11:53:57 +00:00

(Migrated from github.com)

Fixes https://github.com/go-gitea/gitea/issues/16209 for new repositories created. The problem is that hooks in new repositories created when running in snap include the snap revision in the path. As the snap is refreshed the hooks eventually break.
This pull request does not fix repositories already created. Here a good workaround has been suggested by JensTheCoder.
Please be aware that I am a newbie to both gitea, snap and golang.

Fixes https://github.com/go-gitea/gitea/issues/16209 for new repositories created. The problem is that hooks in new repositories created when running in snap include the snap revision in the path. As the snap is refreshed the hooks eventually break. This pull request does not fix repositories already created. Here a good workaround has been suggested by JensTheCoder. Please be aware that I am a newbie to both gitea, snap and golang.

👍 1

wxiaoguang reviewed 2021-09-26 14:06:36 +00:00

modules/setting/setting.go

wxiaoguang commented

2021-09-26 14:06:36 +00:00

Can you write more comments here? It will be easier for other people to understand what the issue is and how it is fixed.

OleHusgaard (Migrated from github.com) reviewed 2021-09-26 14:57:47 +00:00

modules/setting/setting.go

OleHusgaard (Migrated from github.com) commented

2021-09-26 14:57:47 +00:00

I added comments about the problem, and how it is fixed,

wxiaoguang reviewed 2021-09-26 15:35:39 +00:00

modules/setting/setting.go

wxiaoguang commented

2021-09-26 15:35:38 +00:00

Thank you, it's clear for me. I think we should be more careful here:

We should check whether the current path really exists and is valid. If not, an ERROR log should be reported, and fallback to use old AppPath.
We should output an INFO level log to tell users that we are in SNAP and have changed the AppPath for this purpose. Or users may be confused by this behavior (it will be very hard to debug)

Thank you, it's clear for me. I think we should be more careful here: 1. We should check whether the `current` path really exists and is valid. If not, an ERROR log should be reported, and fallback to use old AppPath. 2. We should output an INFO level log to tell users that we are in SNAP and have changed the AppPath for this purpose. Or users may be confused by this behavior (it will be very hard to debug)

This repo is archived. You cannot comment on pull requests.

No reviewers