Site admin could create repos even MAX_CREATION_LIMIT=0 #4645

lunny · 2018-08-08T15:03:02Z

lunny commented

2018-08-08 15:03:02 +00:00

When MAX_CREATION_LIMIT=0, site admin could create repos on any account but not organization, it will result in 500. This PR will fix that issue. That means, site admin could create repos on any account or organization even
MAX_CREATION_LIMIT=0

When MAX_CREATION_LIMIT=0, site admin could create repos on any account but not organization, it will result in 500. This PR will fix that issue. That means, site admin could create repos on any account or organization even MAX_CREATION_LIMIT=0

techknowlogick approved these changes 2018-08-08 15:03:57 +00:00

codecov-io commented

2018-08-08 15:19:20 +00:00

(Migrated from github.com)

Codecov Report

Merging #4645 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4645   +/-   ##
=======================================
  Coverage   20.63%   20.63%           
=======================================
  Files         166      166           
  Lines       32261    32261           
=======================================
  Hits         6657     6657           
  Misses      24626    24626           
  Partials      978      978

Impacted Files	Coverage Δ
models/repo.go	`18.29% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e46499...1c118e6. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=h1) Report > Merging [#4645](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/0e464995cefa381b0bc8703998c1b653ae4e3586?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/4645/graphs/tree.svg?token=t1G57YGbPy&src=pr&width=650&height=150)](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4645 +/- ## ======================================= Coverage 20.63% 20.63% ======================================= Files 166 166 Lines 32261 32261 ======================================= Hits 6657 6657 Misses 24626 24626 Partials 978 978 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [models/repo.go](https://codecov.io/gh/go-gitea/gitea/pull/4645/diff?src=pr&el=tree#diff-bW9kZWxzL3JlcG8uZ28=) | `18.29% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=footer). Last update [0e46499...1c118e6](https://codecov.io/gh/go-gitea/gitea/pull/4645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).