Add Set and UniqueQueue implementations #1

zeripath · 2020-01-16T14:38:30Z

zeripath commented

2020-01-16 14:38:30 +00:00

Whilst looking at replacing the code.gitea.io/gitea/modules/sync.UniqueQueue and code.gitea.io/gitea/modules/sync.Table in Gitea with the new code.gitea.io/gitea/modules/queue.Queue. I realized it would nice to use the leveldb as a set holder.

Adds Set and UniqueQueue implementations.
Adds functions to create Queue, Set & UniqueQueue from an already open leveldb to allow for multiple queues in the same db if desired.

Whilst looking at replacing the `code.gitea.io/gitea/modules/sync.UniqueQueue` and `code.gitea.io/gitea/modules/sync.Table` in Gitea with the new `code.gitea.io/gitea/modules/queue.Queue`. I realized it would nice to use the leveldb as a set holder. * Adds Set and UniqueQueue implementations. * Adds functions to create Queue, Set & UniqueQueue from an already open leveldb to allow for multiple queues in the same db if desired.

lunny commented

2020-01-17 01:20:31 +00:00

So how do you want to use levelqueue like UniqueQueue once the PR merged?

And I think the PR needs some tests.

So how do you want to use `levelqueue` like `UniqueQueue` once the PR merged? And I think the PR needs some tests.

zeripath commented

2020-01-17 17:54:41 +00:00

~~It'd allow me to add UniqueQueue features on top of this - although if you'd prefer I could actually make an unique queue from within this package?~~

Another option would be to create a func From(db leveldb.DB) then we can create a levelqueue from a given levelDB. (Perhaps even be able to stick a prefix on the keys - so you can have more than one queue from a db?)

~~It'd allow me to add UniqueQueue features on top of this - although if you'd prefer I could actually make an unique queue from within this package?~~ ~~Another option would be to create a `func From(db leveldb.DB)` then we can create a levelqueue from a given levelDB. (Perhaps even be able to stick a prefix on the keys - so you can have more than one queue from a db?)~~

zeripath commented

2020-01-17 19:13:23 +00:00

I've just pushed an alternative up, with a new Set and UniqueQueue implementations.

zeripath changed title from ~~Add set commands~~ to Add Set and UniqueQueue implementations

2020-01-17 21:30:55 +00:00

lunny reviewed 2020-01-18 01:32:54 +00:00

Dismissed

uniquequeue.go

													
				@ -0,0 +1,184 @@

				// Copyright 2020 Andrew Thornton. All rights reserved.

lunny commented

2020-01-18 01:32:54 +00:00

How about rename it to unique_queue.go?

How about rename it to `unique_queue.go`?

lunny approved these changes 2020-01-18 01:40:33 +00:00

Dismissed

lunny left a comment

Great! Thanks!

lunny added the

feature

label 2020-01-18 01:41:57 +00:00

lunny added this to the 0.2.0 milestone 2020-01-18 01:42:28 +00:00

lunny referenced this issue from a commit

2020-01-18 05:41:16 +00:00

Add Set and UniqueQueue implementations (#1) Improve documentation Separate out set, uniquequeue and queue Add Has Move to use unique queue Add SIsMember Update README Add redis-like set commands

lunny closed this pull request

2020-01-18 05:41:16 +00:00

zeripath deleted branch add-set-commands

2020-01-18 07:29:53 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/levelqueue#1

				`@ -0,0 +1,184 @@`
				`// Copyright 2020 Andrew Thornton. All rights reserved.`