lunny
/
levelqueue
1
4
Fork 2
Code Issues Pull Requests Actions Releases 1 Activity

Add Set and UniqueQueue implementations #1

Merged
lunny merged 7 commits from zeripath/levelqueue:add-set-commands into master 2020-01-18 05:41:16 +00:00
Conversation 3 Commits 7 Files Changed 8
zeripath commented 2020-01-16 14:38:30 +00:00

Whilst looking at replacing the code.gitea.io/gitea/modules/sync.UniqueQueue and code.gitea.io/gitea/modules/sync.Table in Gitea with the new code.gitea.io/gitea/modules/queue.Queue. I realized it would nice to use the leveldb as a set holder.

  • Adds Set and UniqueQueue implementations.
  • Adds functions to create Queue, Set & UniqueQueue from an already open leveldb to allow for multiple queues in the same db if desired.
Whilst looking at replacing the `code.gitea.io/gitea/modules/sync.UniqueQueue` and `code.gitea.io/gitea/modules/sync.Table` in Gitea with the new `code.gitea.io/gitea/modules/queue.Queue`. I realized it would nice to use the leveldb as a set holder. * Adds Set and UniqueQueue implementations. * Adds functions to create Queue, Set & UniqueQueue from an already open leveldb to allow for multiple queues in the same db if desired.
lunny commented 2020-01-17 01:20:31 +00:00
Owner

So how do you want to use levelqueue like UniqueQueue once the PR merged?

And I think the PR needs some tests.

So how do you want to use `levelqueue` like `UniqueQueue` once the PR merged? And I think the PR needs some tests.
zeripath commented 2020-01-17 17:54:41 +00:00
Poster

It'd allow me to add UniqueQueue features on top of this - although if you'd prefer I could actually make an unique queue from within this package?

Another option would be to create a func From(db leveldb.DB) then we can create a levelqueue from a given levelDB. (Perhaps even be able to stick a prefix on the keys - so you can have more than one queue from a db?)

~~It'd allow me to add UniqueQueue features on top of this - although if you'd prefer I could actually make an unique queue from within this package?~~ ~~Another option would be to create a `func From(db leveldb.DB)` then we can create a levelqueue from a given levelDB. (Perhaps even be able to stick a prefix on the keys - so you can have more than one queue from a db?)~~
zeripath commented 2020-01-17 19:13:23 +00:00
Poster

I've just pushed an alternative up, with a new Set and UniqueQueue implementations.

I've just pushed an alternative up, with a new Set and UniqueQueue implementations.
zeripath changed title from Add set commands to Add Set and UniqueQueue implementations 2020-01-17 21:30:55 +00:00
lunny reviewed 2020-01-18 01:32:54 +00:00
Dismissed
uniquequeue.go
@ -0,0 +1,184 @@
// Copyright 2020 Andrew Thornton. All rights reserved.
lunny commented 2020-01-18 01:32:54 +00:00
Owner

How about rename it to unique_queue.go?

How about rename it to `unique_queue.go`?
lunny approved these changes 2020-01-18 01:40:33 +00:00
Dismissed
lunny left a comment
Owner

Great! Thanks!

Great! Thanks!
lunny added the
feature
 label 2020-01-18 01:41:57 +00:00
lunny added this to the 0.2.0 milestone 2020-01-18 01:42:28 +00:00
lunny closed this pull request 2020-01-18 05:41:16 +00:00
zeripath deleted branch add-set-commands 2020-01-18 07:29:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

Enhancements   
feature

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
0.2.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/levelqueue#1
There is no content yet.
Delete Branch "zeripath/levelqueue:add-set-commands"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?