Make non-compression content-types configurable #2

zeripath · 2020-04-25T14:57:50Z

zeripath commented

2020-04-25 14:57:50 +00:00

First-time contributor

Make non-compression content-types configurable and don't compress text/eventstream by default.

Signed-off-by: Andrew Thornton art27@cantab.net

Make non-compression content-types configurable and don't compress text/eventstream by default. Signed-off-by: Andrew Thornton <art27@cantab.net>

6543 approved these changes 2020-04-26 13:30:39 +00:00

Dismissed

6543 commented

2020-04-26 13:31:02 +00:00

First-time contributor

should we send a pull to https://github.com/go-macaron/gzip too?

guillep2k reviewed 2020-04-28 00:23:14 +00:00

Dismissed

gzip.go

						
				@ -98,0 +123,4 @@

						}

						opt.CompressContentTypesFunc = func(contentType string) bool {

							compress, ok := boolMap[contentType]

guillep2k commented

2020-04-28 00:11:18 +00:00

First-time contributor

Shouldn't this contemplate Content-Type: text/html; charset=....?

https://tools.ietf.org/html/rfc7231#section-3.1.1.5

To get the actual content type, anything after and including ';' must be ignored and then have spaces trimmed.

Shouldn't this contemplate `Content-Type: text/html; charset=....`? https://tools.ietf.org/html/rfc7231#section-3.1.1.5 To get the actual content type, anything after and including ';' must be ignored and then have spaces trimmed.

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: macaron/gzip#2