Update i18n to allow setting samesite #7

zeripath · 2020-11-11T18:37:24Z

zeripath commented

2020-11-11 18:37:24 +00:00

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath force-pushed setCookie-samesite from 3bb53248b9 to c6769d4052

2020-11-11 18:47:33 +00:00

Compare

silverwind approved these changes 2020-11-11 20:30:13 +00:00

Dismissed

6543 approved these changes 2020-11-11 20:46:25 +00:00

Dismissed

mrsdizzie reviewed 2020-11-11 20:56:07 +00:00

Dismissed

i18n.go Outdated

						
				@ -113,6 +115,8 @@ type Options struct {

					Secure bool

					// Set the HTTP Only flag on the `lang` cookie. Default is disabled.

					CookieHttpOnly bool

					// Set the SameSite flag o the `lang` cookie. Default is unset

mrsdizzie commented

2020-11-11 20:56:07 +00:00

First-time contributor

Set the SameSite flag on*

zeripath commented

2020-11-11 21:10:49 +00:00

done.

zeripath marked this conversation as resolved

zeripath added 1 commit 2020-11-11 21:10:41 +00:00

fix doc

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

82e6800263

6543 commented

2020-11-11 21:27:52 +00:00

First-time contributor

?

lunny merged commit 0d444cb714 into master

2020-11-12 07:45:45 +00:00

lunny referenced this issue from a commit

2020-11-12 07:45:45 +00:00

Update i18n to allow setting samesite (#7)

6543 commented

2020-11-29 18:15:01 +00:00

First-time contributor

upstream: https://github.com/go-macaron/i18n/pull/12

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

4 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: macaron/i18n#7