Add interface for Engine & Session #23

lunny · 2017-04-18T18:11:27Z

lunny commented

2017-04-18 18:11:27 +00:00

We would like to mock Engine and Session structs in our code using https://github.com/golang/mock . To do that we need interface for Engine and Session. Changes required are:

Add the new interfaces to core package.
Update xorm pkg's implementation to match these new interfaces. The main change required is to use use the Session interface in xorm.Engine struct. It be something like: https://github.com/go-xorm/xorm/compare/master...appscode:mock?expand=1

@lunny, does this sound acceptable?

Author: @tamalsaha We would like to mock Engine and Session structs in our code using https://github.com/golang/mock . To do that we need `interface` for Engine and Session. Changes required are: - Add the new interfaces to core package. - Update xorm pkg's implementation to match these new interfaces. The main change required is to use use the Session interface in xorm.Engine struct. It be something like: https://github.com/go-xorm/xorm/compare/master...appscode:mock?expand=1 @lunny, does this sound acceptable?

lunny commented

2017-04-19 08:48:06 +00:00

Author: @lunny

Looks great but I don't know how to use mock to do tests.

Author: @lunny Looks great but I don't know how to use mock to do tests.

lunny commented

2017-04-19 14:33:24 +00:00

Author: @tamalsaha

@lunny , basically you can generate a mock implementation based on the interface (or use a reflection based mock). The mock records calls and args. Unit tests can check for those. See docs here: https://godoc.org/github.com/golang/mock/gomock

One more thing that needs to be added to Session is AutoClose().

Author: @tamalsaha @lunny , basically you can generate a mock implementation based on the interface (or use a reflection based mock). The mock records calls and args. Unit tests can check for those. See docs here: https://godoc.org/github.com/golang/mock/gomock One more thing that needs to be added to Session is `AutoClose()`.

lunny commented

2017-11-15 08:24:17 +00:00

Author: @lunny

@tamalsaha see https://github.com/go-xorm/xorm/blob/master/interface.go

Author: @lunny @tamalsaha see https://github.com/go-xorm/xorm/blob/master/interface.go

This repo is archived. You cannot comment on pull requests.

No reviewers