Add extends tests for new qualifying algorithm #13

lunny · 2016-05-19T16:39:19Z

lunny commented

2016-05-19 16:39:19 +00:00

Author: @gavv

We need this PR for go-xorm/xorm#398

Author: @gavv We need this PR for go-xorm/xorm#398

lunny commented

2016-05-19 18:39:55 +00:00

Author: @gavv

What do you think about using testify for xorm tests?

I think it would reduce code size dramatically, e.g. you can replace:

if list[0].Sender != e.sender {
    err := errors.New(fmt.Sprintln("should sender equal", list[0].Sender, e.sender))
    t.Error(err)
    panic(err)
}

with:

require.Equal(t, e.sender, list[0].Sender)

require.Equal will produce nice error message (with compact diff and backtrace) on failure and terminate test.

Author: @gavv What do you think about using [`testify`](https://github.com/stretchr/testify/) for xorm tests? I think it would reduce code size dramatically, e.g. you can replace: ``` go if list[0].Sender != e.sender { err := errors.New(fmt.Sprintln("should sender equal", list[0].Sender, e.sender)) t.Error(err) panic(err) } ``` with: ``` go require.Equal(t, e.sender, list[0].Sender) ``` `require.Equal` will produce nice error message (with compact diff and backtrace) on failure and terminate test.

lunny commented

2016-05-20 00:19:22 +00:00

Author: @lunny

Looks like testify is a good idea.

Author: @lunny Looks like testify is a good idea.

This repo is archived. You cannot comment on pull requests.

No reviewers