fix #997 group by #1065

lunny · 2018-08-09T03:35:51Z

lunny commented

2018-08-09 03:35:51 +00:00

No description provided.

lunny commented

2018-08-09 03:36:05 +00:00

will fix #997

codecov-io commented

2018-08-09 04:05:13 +00:00

(Migrated from github.com)

Codecov Report

Merging #1065 into master will increase coverage by 0.03%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage    54.3%   54.33%   +0.03%     
==========================================
  Files          41       41              
  Lines        7557     7562       +5     
==========================================
+ Hits         4104     4109       +5     
  Misses       2936     2936              
  Partials      517      517

Impacted Files	Coverage Δ
statement.go	`66.84% <0%> (ø)`	⬆️
session_query.go	`61.74% <0%> (ø)`	⬆️
engine.go	`61.72% <100%> (+0.21%)`	⬆️
session_find.go	`68.33% <50%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce90f9...ae4f999. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=h1) Report > Merging [#1065](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/4ce90f9a62d8f656b6dd55d80404cf3cf8b1894e?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `54.54%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1065/graphs/tree.svg?height=150&width=650&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1065 +/- ## ========================================== + Coverage 54.3% 54.33% +0.03% ========================================== Files 41 41 Lines 7557 7562 +5 ========================================== + Hits 4104 4109 +5 Misses 2936 2936 Partials 517 517 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/1065/diff?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `66.84% <0%> (ø)` | :arrow_up: | | [session\_query.go](https://codecov.io/gh/go-xorm/xorm/pull/1065/diff?src=pr&el=tree#diff-c2Vzc2lvbl9xdWVyeS5nbw==) | `61.74% <0%> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1065/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.72% <100%> (+0.21%)` | :arrow_up: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/1065/diff?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `68.33% <50%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=footer). Last update [4ce90f9...ae4f999](https://codecov.io/gh/go-xorm/xorm/pull/1065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

fix #997 group by (#1065)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1065