fix db default charset error #1072

lunny · 2018-08-17T00:40:07Z

zhenbeiju commented

2018-08-17 00:40:07 +00:00

(Migrated from github.com)

No description provided.

codecov-io commented

2018-08-25 05:26:35 +00:00

(Migrated from github.com)

Codecov Report

Merging #1072 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1072      +/-   ##
=========================================
- Coverage   54.32%   54.3%   -0.02%     
=========================================
  Files          41      41              
  Lines        7564    7564              
=========================================
- Hits         4109    4108       -1     
  Misses       2937    2937              
- Partials      518     519       +1

Impacted Files	Coverage Δ
dialect_mysql.go	`59.39% <100%> (ø)`	⬆️
xorm.go	`64.61% <0%> (-1.54%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b080b7...d87e921. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=h1) Report > Merging [#1072](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/5b080b74958604862aecc216d8ac47c4f7692e69?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1072/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1072 +/- ## ========================================= - Coverage 54.32% 54.3% -0.02% ========================================= Files 41 41 Lines 7564 7564 ========================================= - Hits 4109 4108 -1 Misses 2937 2937 - Partials 518 519 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [dialect\_mysql.go](https://codecov.io/gh/go-xorm/xorm/pull/1072/diff?src=pr&el=tree#diff-ZGlhbGVjdF9teXNxbC5nbw==) | `59.39% <100%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1072/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <0%> (-1.54%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=footer). Last update [5b080b7...d87e921](https://codecov.io/gh/go-xorm/xorm/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2018-08-25 12:34:51 +00:00

Thanks

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

fix db default charset error (#1072) * fix db default charset error * add table charset empty check

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1072