fix session_find & session_get getCacher param error #1131

lunny · 2018-11-01T09:26:20Z

Slory7 commented

2018-11-01 09:26:20 +00:00

(Migrated from github.com)

Should use session.statement.TableName() instead of table.Name. When one table's name is different from the struct's name, table.Name will be wrong.

codecov-io commented

2018-11-01 09:43:03 +00:00

(Migrated from github.com)

Codecov Report

Merging #1131 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1131   +/-   ##
======================================
  Coverage    54.7%   54.7%           
======================================
  Files          42      42           
  Lines        7646    7646           
======================================
  Hits         4183    4183           
  Misses       2935    2935           
  Partials      528     528

Impacted Files	Coverage Δ
session_get.go	`76.87% <100%> (ø)`	⬆️
session_delete.go	`58.97% <100%> (ø)`	⬆️
session_find.go	`68.33% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01dd69d...21de1dc. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=h1) Report > Merging [#1131](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/01dd69d3903326b5293e4e3470877e2cdc0efd4a?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1131/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1131 +/- ## ====================================== Coverage 54.7% 54.7% ====================================== Files 42 42 Lines 7646 7646 ====================================== Hits 4183 4183 Misses 2935 2935 Partials 528 528 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1131/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `76.87% <100%> (ø)` | :arrow_up: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/1131/diff?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.97% <100%> (ø)` | :arrow_up: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/1131/diff?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `68.33% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=footer). Last update [01dd69d...21de1dc](https://codecov.io/gh/go-xorm/xorm/pull/1131?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

fix session_find & session_get getCacher param error (#1131) * fix session_delete getCacher tablename param error * fix session_find & session_get getCacher param error

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1131