xorm/xorm
xorm/xorm
64
359
Fork 208
Code Issues 373 Pull Requests 18 Actions Releases 35 Activity

Fix exporting values into Postgres #1186

Merged
gzsombor merged 1 commits from postgres-import into master 2019-01-09 08:18:51 +00:00
Conversation 2 Commits 1 Files Changed 2 +8 -3
gzsombor commented 2019-01-09 07:58:29 +00:00 (Migrated from github.com)
Copy Link

Fixing go-gitea/gitea#5651

  • UUID and BOOL type shouldn't have a length field
  • Incorrect quoting cause that the column names are selected instead of the column values
Fixing go-gitea/gitea#5651 * UUID and BOOL type shouldn't have a length field * Incorrect quoting cause that the column names are selected instead of the column values
codecov-io commented 2019-01-09 08:15:19 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #1186 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
+ Coverage   54.69%   54.69%   +<.01%     
==========================================
  Files          42       42              
  Lines        7646     7649       +3     
==========================================
+ Hits         4182     4184       +2     
- Misses       2935     2936       +1     
  Partials      529      529
Impacted Files Coverage Δ
engine.go 61.52% <0%> (-0.07%) ⬇️
dialect_postgres.go 75.72% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f0a71...b255dcb. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=h1) Report > Merging [#1186](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/a8f0a7110a8049c79069836b420538f1964e6339?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `50%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1186/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1186 +/- ## ========================================== + Coverage 54.69% 54.69% +<.01% ========================================== Files 42 42 Lines 7646 7649 +3 ========================================== + Hits 4182 4184 +2 - Misses 2935 2936 +1 Partials 529 529 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1186/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.52% <0%> (-0.07%)` | :arrow_down: | | [dialect\_postgres.go](https://codecov.io/gh/go-xorm/xorm/pull/1186/diff?src=pr&el=tree#diff-ZGlhbGVjdF9wb3N0Z3Jlcy5nbw==) | `75.72% <100%> (+0.15%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=footer). Last update [a8f0a71...b255dcb](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
codecov-io commented 2019-01-09 08:15:19 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #1186 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
+ Coverage   54.69%   54.69%   +<.01%     
==========================================
  Files          42       42              
  Lines        7646     7649       +3     
==========================================
+ Hits         4182     4184       +2     
- Misses       2935     2936       +1     
  Partials      529      529
Impacted Files Coverage Δ
engine.go 61.52% <0%> (-0.07%) ⬇️
dialect_postgres.go 75.72% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f0a71...b255dcb. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=h1) Report > Merging [#1186](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/a8f0a7110a8049c79069836b420538f1964e6339?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `50%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1186/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1186 +/- ## ========================================== + Coverage 54.69% 54.69% +<.01% ========================================== Files 42 42 Lines 7646 7649 +3 ========================================== + Hits 4182 4184 +2 - Misses 2935 2936 +1 Partials 529 529 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1186/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.52% <0%> (-0.07%)` | :arrow_down: | | [dialect\_postgres.go](https://codecov.io/gh/go-xorm/xorm/pull/1186/diff?src=pr&el=tree#diff-ZGlhbGVjdF9wb3N0Z3Jlcy5nbw==) | `75.72% <100%> (+0.15%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=footer). Last update [a8f0a71...b255dcb](https://codecov.io/gh/go-xorm/xorm/pull/1186?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
0.8
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1186
No description provided.
Delete Branch "postgres-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?