refactor/mssql: change default sizing of binary columns to max when length is not defined #1487

sapk · 2019-12-01T23:59:03Z

sapk commented

2019-12-01 23:59:03 +00:00

First-time contributor

I have gone with the first suggestion in #1484

I will try to do another PR later for MAX -> -1 -> MAX but I didn't have all the insight on xorm and core to do it directly.

I have gone with the first suggestion in https://gitea.com/xorm/xorm/issues/1484 I will try to do another PR later for MAX -> -1 -> MAX but I didn't have all the insight on xorm and core to do it directly.

lunny requested changes 2019-12-02 01:11:32 +00:00

Dismissed

lunny left a comment

That's why ci failed.

types_test.go Outdated

						
				@ -102,0 +104,4 @@

				func TestGetBytesMax(t *testing.T) {

					assert.NoError(t, prepareEngine())

					type Varbinary struct {

lunny commented

2019-12-02 01:11:18 +00:00

Please use different struct name.

sapk commented

2019-12-02 14:40:15 +00:00

First-time contributor

done

lunny added the

kind

bug

label 2019-12-02 01:11:40 +00:00

lunny added this to the 0.8.2 milestone 2019-12-02 01:11:47 +00:00

sapk commented

2020-01-08 09:47:45 +00:00

First-time contributor

@lunny Can you restart CI build ?
It seems to have failed for an unrelated isssue:

fatal: unable to access 'https://github.com/go-sql-driver/mysql/': Failed to connect to github.com port 443: Connection timed out

@lunny Can you restart CI build ? It seems to have failed for an unrelated isssue: ``` fatal: unable to access 'https://github.com/go-sql-driver/mysql/': Failed to connect to github.com port 443: Connection timed out ```

lunny commented

2020-01-08 12:27:10 +00:00

Someting wrong of the CI. I will check what's the problem.