Add Hook #1644

Merged
lunny merged 2 commits from yxlimo/xorm:master into master 2 years ago
yxlimo commented 2 years ago
There is no content yet.
Owner

@limo.creed Maybe we should move the Hook to a standalone package? And could you add some tests?

@limo.creed Maybe we should move the Hook to a standalone package? And could you add some tests?
lunny added the
kind/feature
label 2 years ago
Poster

@limo.creed Maybe we should move the Hook to a standalone package? And could you add some tests?

i will add some tests later.

and i am consider that use LogContext is not a good way.

maybe use a new struct instead is better, like QueryContext ?

> @limo.creed Maybe we should move the Hook to a standalone package? And could you add some tests? i will add some tests later. and i am consider that use `LogContext` is not a good way. maybe use a new struct instead is better, like `QueryContext` ?
Poster

@lunny i added some tests and move it alone

@lunny i added some tests and move it alone
Owner

Please resolve the conflicts.

Please resolve the conflicts.
Poster

@lunny resolved

@lunny resolved
Owner

How about move Hook to contexts package but not a new sub package? This should be the last thinking about this PR.

How about move `Hook` to `contexts` package but not a new sub package? This should be the last thinking about this PR.
Poster

seems good. i have moved in contexts

seems good. i have moved in `contexts`
lunny approved these changes 2 years ago
Dismissed
lunny closed this pull request 2 years ago
lunny added this to the 1.0.2 milestone 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 34dc7f8791.
Sign in to join this conversation.
Loading…
There is no content yet.