xorm/xorm
xorm/xorm
64
358
Fork 207
Code Issues 373 Pull Requests 18 Actions 9 Releases 35 Activity

chore: improve snakeCasedName performance #1688

Merged
lunny merged 3 commits from performance into master 2020-05-22 02:54:50 +00:00
Conversation 4 Commits 3 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fdb6765648 - Show all commits

2
names/mapper.go
View File

@ -98,7 +98,7 @@ func b2s(b []byte) string {
}
func snakeCasedNameNew(name string) string {
newstr := make([]byte, 0)
newstr := make([]byte, 0, len(name))
lunny commented 2020-05-21 14:03:29 +00:00
Outdated
Review
Copy Link

How about give a length ? make([]byte, 0, len(name))

How about give a length ? `make([]byte, 0, len(name)) `
appleboy commented 2020-05-21 14:16:54 +00:00
Outdated
Review
Copy Link

Done.

goos: darwin
goarch: amd64
pkg: xorm.io/xorm/names
BenchmarkSnakeCasedName-8         313640              3524 ns/op            2328 B/op          9 allocs/op
BenchmarkSnakeCasedNameNew-8     1901515               617 ns/op             576 B/op          2 allocs/op
PASS
ok      xorm.io/xorm/names      2.976s
Done. ``` goos: darwin goarch: amd64 pkg: xorm.io/xorm/names BenchmarkSnakeCasedName-8 313640 3524 ns/op 2328 B/op 9 allocs/op BenchmarkSnakeCasedNameNew-8 1901515 617 ns/op 576 B/op 2 allocs/op PASS ok xorm.io/xorm/names 2.976s ```
lunny commented 2020-05-21 14:25:41 +00:00
Outdated
Review
Copy Link

Sorry, maybe newstr := make([]byte, 0, len(name)+1 is better.

Sorry, maybe `newstr := make([]byte, 0, len(name)+1` is better.
appleboy commented 2020-05-21 14:30:03 +00:00
Review
Copy Link

Done

Done
for i := 0; i < len(name); i++ {
c := name[i]
if isUpper := 'A' <= c && c <= 'Z'; isUpper {