xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 368 Pull Requests 16 Actions Releases 35 Activity

Support get dataSourceName on ContextHook for monitor which DB executed SQL #1740

Merged
lunny merged 9 commits from Thomas_An/thomasan_xorm:master into master 2020-07-13 13:30:29 +00:00
Conversation 10 Commits 9 Files Changed 4 +20 -2
Thomas_An commented 2020-07-09 09:51:34 +00:00
Contributor
Copy Link
No description provided.
Thomas_An added 2 commits 2020-07-09 09:51:37 +00:00
session add Engine func
All checks were successful
continuous-integration/drone/pr Build is passing
Details
3a48920a98
Thomas_An changed title from WIP: support get dataSourceName on ContextHook for to WIP: support get dataSourceName on ContextHook for monitor which DB executed SQL 2020-07-09 09:52:12 +00:00
Thomas_An changed title from WIP: support get dataSourceName on ContextHook for monitor which DB executed SQL to Support get dataSourceName on ContextHook for monitor which DB executed SQL 2020-07-09 10:17:39 +00:00
Thomas_An started working 2020-07-09 11:45:27 +00:00
lunny added the
kind
enhancement
 label 2020-07-09 15:06:16 +00:00
Thomas_An commented 2020-07-10 08:55:45 +00:00
Author
Contributor
Copy Link

@lunny Can help merge the code into the master?

@lunny Can help merge the code into the master?
lunny commented 2020-07-10 09:13:50 +00:00
Owner
Copy Link

Could you add some tests for this PR?

Could you add some tests for this PR?
Thomas_An added 1 commit 2020-07-10 13:46:56 +00:00
add test code
All checks were successful
continuous-integration/drone/pr Build is passing
Details
06f24231f2
Thomas_An added 1 commit 2020-07-10 13:49:31 +00:00
Merge branch 'master' into master
All checks were successful
continuous-integration/drone/pr Build is passing
Details
46cf5a88d5
Thomas_An commented 2020-07-10 14:10:50 +00:00
Author
Contributor
Copy Link

@lunny test code has been submitted,please help review

@lunny test code has been submitted,please help review
lunny commented 2020-07-11 05:57:17 +00:00
Owner
Copy Link

@Thomas_An Thanks! How will you want to use this feature?

@Thomas_An Thanks! How will you want to use this feature?
Thomas_An commented 2020-07-12 08:43:58 +00:00
Author
Contributor
Copy Link

@lunny Hope to be online before the 24th of this month

@lunny Hope to be online before the 24th of this month
lunny commented 2020-07-12 16:00:49 +00:00
Owner
Copy Link

@Thomas_An I mean could you give some example codes about how will you use the new feature?

@Thomas_An I mean could you give some example codes about how will you use the new feature?
Thomas_An commented 2020-07-13 02:05:59 +00:00
Author
Contributor
Copy Link

@lunny example:
image
image

@lunny example: ![image](/attachments/bf1ae6e9-9453-42dc-b52e-a42c02a0b7e9) ![image](/attachments/7306fc50-be15-4747-a2a0-bafddd3bd378)
image.png
200 KiB
image.png
103 KiB
Thomas_An commented 2020-07-13 02:08:18 +00:00
Author
Contributor
Copy Link

do you have a better solution?

do you have a better solution?
lunny commented 2020-07-13 04:16:03 +00:00
Owner
Copy Link

Maybe just put the session directly?

ctx = context.WithValue(engine.defaultContext, log.SessionKey, session)
Maybe just put the session directly? ```go ctx = context.WithValue(engine.defaultContext, log.SessionKey, session) ```
lunny added this to the 1.0.4 milestone 2020-07-13 04:16:16 +00:00
Thomas_An added 2 commits 2020-07-13 07:52:22 +00:00
Merge branch 'master' of https://gitea.com/Thomas_An/thomasan_xorm
All checks were successful
continuous-integration/drone/pr Build is passing
Details
372a2403e8
lunny requested changes 2020-07-13 08:20:28 +00:00
Dismissed
lunny left a comment
Owner
Copy Link

The session id should be kept both to keep compitable as before.

The session id should be kept both to keep compitable as before.
Thomas_An requested review from lunny 2020-07-13 10:03:26 +00:00
Thomas_An added 3 commits 2020-07-13 10:24:54 +00:00
Merge branch 'log_context_add_db_info'
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7a1a1c04be
lunny approved these changes 2020-07-13 13:29:00 +00:00
Dismissed
lunny merged commit 0fae64bb3b into master 2020-07-13 13:29:43 +00:00
lunny commented 2020-07-13 13:29:52 +00:00
Owner
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.0.4
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1740
No description provided.
Delete Branch "Thomas_An/thomasan_xorm:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?