Labels Milestones

Support get dataSourceName on ContextHook for monitor which DB executed SQL #1740

Merged

lunny merged 9 commits from Thomas_An/thomasan_xorm:master into master 3 years ago

Conversation 10 Commits 9 Files Changed 4

Thomas_An commented 3 years ago

There is no content yet.

Thomas_An changed title from WIP: support get dataSourceName on ContextHook for to WIP: support get dataSourceName on ContextHook for monitor which DB executed SQL 3 years ago

Thomas_An changed title from WIP: support get dataSourceName on ContextHook for monitor which DB executed SQL to Support get dataSourceName on ContextHook for monitor which DB executed SQL 3 years ago

Thomas_An started working 3 years ago

lunny added the

kind

enhancement

label 3 years ago

Thomas_An commented 3 years ago

Poster

@lunny Can help merge the code into the master?

@lunny Can help merge the code into the master?

lunny commented 3 years ago

Owner

Could you add some tests for this PR?

Could you add some tests for this PR?

Thomas_An commented 3 years ago

Poster

@lunny test code has been submitted,please help review

@lunny test code has been submitted,please help review

lunny commented 3 years ago

Owner

@Thomas_An Thanks! How will you want to use this feature?

@Thomas_An Thanks! How will you want to use this feature?

Thomas_An commented 3 years ago

Poster

@lunny Hope to be online before the 24th of this month

@lunny Hope to be online before the 24th of this month

lunny commented 3 years ago

Owner

@Thomas_An I mean could you give some example codes about how will you use the new feature?

@Thomas_An I mean could you give some example codes about how will you use the new feature?

Thomas_An commented 3 years ago

Poster

@lunny example:

@lunny example:  

image.png

200 KiB

image.png

103 KiB

Thomas_An commented 3 years ago

Poster

do you have a better solution?

do you have a better solution?

lunny commented 3 years ago

Owner

Maybe just put the session directly?

ctx = context.WithValue(engine.defaultContext, log.SessionKey, session)

Maybe just put the session directly? ```go ctx = context.WithValue(engine.defaultContext, log.SessionKey, session) ```

lunny added this to the 1.0.4 milestone 3 years ago

lunny requested changes 3 years ago

Dismissed

lunny left a comment

Owner

The session id should be kept both to keep compitable as before.

The session id should be kept both to keep compitable as before.

Thomas_An requested review from lunny 3 years ago

lunny approved these changes 3 years ago

Dismissed

lunny referenced this issue from a commit 3 years ago

Support get dataSourceName on ContextHook for monitor which DB executed SQL (#1740)

lunny merged commit 0fae64bb3b into master 3 years ago

lunny commented 3 years ago

Owner

Thanks!

Thanks!

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 0fae64bb3b.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

blocked

  

db

oracle

  

db

sqlserver

  

duplicate

  

feature

cache

  

invalid

  

kind

breaking

  

kind

bug

  

kind

build

  

kind

dependencies

  

kind

docs

  

kind

driver

  

kind

enhancement

  

kind

feature

  

kind

performance

  

kind

proposal

  

kind

question

  

kind

refactor

  

kind

testing

  

need

feedback

  

need

test

  

proposal:accepted

  

RaspBerry Pi

  

regression

  

skip-changelog

  

upstream

  

wip

  

wontfix

No Label

blocked

db

oracle

db

sqlserver

duplicate

feature

cache

invalid

kind

breaking

kind

bug

kind

build

kind

dependencies

kind

docs

kind

driver

kind

enhancement

kind

feature

kind

performance

kind

proposal

kind

question

kind

refactor

kind

testing

need

feedback

need

test

proposal:accepted

RaspBerry Pi

regression

skip-changelog

upstream

wip

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

1.0.4

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1740

Write Preview

Loading…

Cancel Save

There is no content yet.