Fix two issues with dumptables #1903

zeripath · 2021-05-07T23:38:55Z

zeripath commented

2021-05-07 23:38:55 +00:00

There are two issues with #1872 which have become apparent
after testing on Gitea.

Ensure structs which are have before processors run correctly
Ensure structs extending other structs work
Ensure that numerical enums become numeric

Signed-off-by: Andrew Thornton art27@cantab.net

There are two issues with #1872 which have become apparent after testing on Gitea. 1. Ensure structs which are have before processors run correctly 2. Ensure structs extending other structs work 3. Ensure that numerical enums become numeric Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added 1 commit 2021-05-07 23:38:56 +00:00

Fix two issues with dumptables

There are two issues with #1872 which have become apparent
after testing on Gitea.

1. Ensure structs which are have before processors run correctly
2. Ensure structs extending other structs work

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

0dc75b7ad6

zeripath added 1 commit 2021-05-08 00:09:18 +00:00

And deal with numerical enums too

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

08e4baedd3

zeripath commented

2021-05-08 00:21:25 +00:00

There's a problem with slices too that needs sorting.

One interesting thing the change does is reset the nulls to default values. I'm not certain if that is really intentional but it does seem benenficial.

There's a problem with slices too that needs sorting. One interesting thing the change does is reset the nulls to default values. I'm not certain if that is really intentional but it does seem benenficial.

lunny approved these changes 2021-05-08 04:27:16 +00:00

lunny merged commit 210c30a7dd into master

2021-05-08 04:27:22 +00:00

lunny referenced this issue from a commit

2021-05-08 04:27:23 +00:00

Fix two issues with dumptables (#1903)

zeripath deleted branch fix-1872-issues

2021-05-08 10:02:52 +00:00

lunny added this to the 1.1.0 milestone 2021-05-14 09:10:18 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1903