Fix two issues with dumptables #1903

Merged
lunny merged 2 commits from zeripath/xorm:fix-1872-issues into master 7 months ago

There are two issues with #1872 which have become apparent
after testing on Gitea.

  1. Ensure structs which are have before processors run correctly
  2. Ensure structs extending other structs work
  3. Ensure that numerical enums become numeric

Signed-off-by: Andrew Thornton art27@cantab.net

There are two issues with #1872 which have become apparent after testing on Gitea. 1. Ensure structs which are have before processors run correctly 2. Ensure structs extending other structs work 3. Ensure that numerical enums become numeric Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 7 months ago
0dc75b7ad6
Fix two issues with dumptables
zeripath added 1 commit 7 months ago
08e4baedd3
And deal with numerical enums too
Poster

There's a problem with slices too that needs sorting.

One interesting thing the change does is reset the nulls to default values. I'm not certain if that is really intentional but it does seem benenficial.

There's a problem with slices too that needs sorting. One interesting thing the change does is reset the nulls to default values. I'm not certain if that is really intentional but it does seem benenficial.
lunny approved these changes 7 months ago
lunny merged commit 210c30a7dd into master 7 months ago
lunny referenced this issue from a commit 7 months ago
zeripath deleted branch fix-1872-issues 7 months ago
lunny added this to the 1.1.0 milestone 7 months ago

Reviewers

lunny approved these changes 7 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 210c30a7dd.
Sign in to join this conversation.
Loading…
There is no content yet.