Ignore comments when deciding when to replace question marks. #1954 #1955

Merged
lunny merged 2 commits from antialiasis/xorm:issue-1954 into master 5 months ago

This should solve #1954 and adds some tests for it. I will note I'm not 100% clear on whether there are other edge cases that should be covered here. From what I understand the only standard SQL way to escape single quotes is to double them, which shouldn't cause any problems with this, but if some SQL flavors allow other kinds of escaping, for instance, that would probably need to be covered too for ideal results.

This should solve #1954 and adds some tests for it. I will note I'm not 100% clear on whether there are other edge cases that should be covered here. From what I understand the only standard SQL way to escape single quotes is to double them, which shouldn't cause any problems with this, but if some SQL flavors allow other kinds of escaping, for instance, that would probably need to be covered too for ideal results.
antialiasis added 1 commit 6 months ago
antialiasis changed title from Ignore comments when deciding when to replace quetion marks. #1954 to Ignore comments when deciding when to replace question marks. #1954 6 months ago
Poster

I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated.

I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated.
Owner

I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated.

It should be a bug of mssql driver and not related with this PR.

> I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated. It should be a bug of mssql driver and not related with this PR.
lunny added 1 commit 6 months ago
180bd9a5a3 Merge branch 'master' into issue-1954
lunny approved these changes 5 months ago
lunny added the
kind/bug
label 5 months ago
lunny merged commit 44f892fddc into master 5 months ago
lunny added this to the 1.1.1 milestone 5 months ago

Reviewers

lunny approved these changes 5 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 44f892fddc.
Sign in to join this conversation.
Loading…
There is no content yet.